Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined featureFlagSegmentInclusion and featureFlagSegmentExclusion errors #1833

Merged
merged 7 commits into from
Aug 20, 2024
Merged

Fix undefined featureFlagSegmentInclusion and featureFlagSegmentExclusion errors #1833

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
94e6ac2
Fix undefined featureFlagSegmentInclusion and featureFlagSegmentExclu…
zackcl Aug 19, 2024
0510e91
Merge branch 'dev' into bugfix/ff-reducer-undefined
zackcl Aug 19, 2024
2db4618
Merge branch 'dev' into bugfix/ff-reducer-undefined
zackcl Aug 19, 2024
992248e
Merge branch 'dev' into bugfix/ff-reducer-undefined
zackcl Aug 19, 2024
f87649d
Merge branch 'dev' into bugfix/ff-reducer-undefined
danoswaltCL Aug 19, 2024
5984008
Merge branch 'dev' into bugfix/ff-reducer-undefined
danoswaltCL Aug 19, 2024
bb00568
Merge branch 'dev' into bugfix/ff-reducer-undefined
zackcl Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions frontend/projects/upgrade/src/app/core/feature-flags/store/feature-flags.reducer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,10 @@ const reducer = createReducer(
const existingFlag = state.entities[featureFlag?.id];

if (existingFlag) {
const updatedInclusions = existingFlag.featureFlagSegmentInclusion.map((inclusion) =>
inclusion.segment.id === listResponse.segment.id ? listResponse : inclusion
);
const updatedInclusions =
existingFlag.featureFlagSegmentInclusion?.map((inclusion) =>
inclusion.segment.id === listResponse.segment.id ? listResponse : inclusion
) ?? [];

return adapter.updateOne(
{
Expand All @@ -174,14 +175,13 @@ const reducer = createReducer(
on(FeatureFlagsActions.actionDeleteFeatureFlagInclusionListSuccess, (state, { segmentId }) => {
const updatedState = { ...state, isLoadingUpsertPrivateSegmentList: false };
const flagId = Object.keys(state.entities).find((id) =>
state.entities[id].featureFlagSegmentInclusion.some((inclusion) => inclusion.segment.id === segmentId)
state.entities[id].featureFlagSegmentInclusion?.some((inclusion) => inclusion.segment.id === segmentId)
);

if (flagId) {
const flag = state.entities[flagId];
const updatedInclusions = flag.featureFlagSegmentInclusion.filter(
(inclusion) => inclusion.segment.id !== segmentId
);
const updatedInclusions =
flag.featureFlagSegmentInclusion?.filter((inclusion) => inclusion.segment.id !== segmentId) ?? [];

return adapter.updateOne(
{
Expand Down Expand Up @@ -226,9 +226,10 @@ const reducer = createReducer(
const existingFlag = state.entities[featureFlag?.id];

if (existingFlag) {
const updatedExclusions = existingFlag.featureFlagSegmentExclusion.map((exclusion) =>
exclusion.segment.id === listResponse.segment.id ? listResponse : exclusion
);
const updatedExclusions =
existingFlag.featureFlagSegmentExclusion?.map((exclusion) =>
exclusion.segment.id === listResponse.segment.id ? listResponse : exclusion
) ?? [];

return adapter.updateOne(
{
Expand All @@ -250,14 +251,13 @@ const reducer = createReducer(
on(FeatureFlagsActions.actionDeleteFeatureFlagExclusionListSuccess, (state, { segmentId }) => {
const updatedState = { ...state, isLoadingUpsertPrivateSegmentList: false };
const flagId = Object.keys(state.entities).find((id) =>
state.entities[id].featureFlagSegmentExclusion.some((exclusion) => exclusion.segment.id === segmentId)
state.entities[id].featureFlagSegmentExclusion?.some((exclusion) => exclusion.segment.id === segmentId)
);

if (flagId) {
const flag = state.entities[flagId];
const updatedExclusions = flag.featureFlagSegmentExclusion.filter(
(exclusion) => exclusion.segment.id !== segmentId
);
const updatedExclusions =
flag.featureFlagSegmentExclusion?.filter((exclusion) => exclusion.segment.id !== segmentId) ?? [];

return adapter.updateOne(
{
Expand Down
Loading