Fix undefined featureFlagSegmentInclusion and featureFlagSegmentExclusion errors #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackcl
requested review from
bcb37,
ppratikcr7,
RidhamShah,
Yagnik56 and
danoswaltCL
|
Love explanation in the PR of the changes, I assume this was GPT assisted? How did you prompt it? |
danoswaltCL
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes a bug where undefined
featureFlagSegmentInclusionandfeatureFlagSegmentExclusionproperties were sometimes causing runtime errors (e.g.,TypeError: Cannot read properties of undefined (reading 'some')) in the Feature Flags reducer while deleting or updating an include/exclude list (The error seemed to happen randomly when there are many feature flags and include/exclude lists defined).Key Changes:
Added optional chaining (
?.) to featureFlagSegmentInclusion and featureFlagSegmentExclusion property accesses.Implemented fallback to empty arrays (
?? []) when these properties are undefined.Bug Fixed:
Resolves "Cannot read properties of undefined" errors occurring when accessing or operating on
featureFlagSegmentInclusionorfeatureFlagSegmentExclusion.Testing: