Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Exclude List Row Actions #1826

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

zackcl
Copy link
Collaborator

@zackcl zackcl commented Aug 13, 2024

This PR implements Edit/Delete actions for rows in the Exclude List table on the Feature Flag details page.

Resolves #1757, resolves #1775, resolves #1776, resolves #1818, resolves #1819, resolves #1820, resolves #1754

…xclusion in selectSelectedFeatureFlag selector
@zackcl zackcl marked this pull request as ready for review August 13, 2024 13:15
@danoswaltCL
Copy link
Collaborator

Just a couple minor comments, I think this should be good. I hope you found working with the UpsertPrivateSegmentListModal to be easy breezy.

…SegmentExclusion in selectSelectedFeatureFlag selector"

This reverts commit 4dc742a.
@zackcl
Copy link
Collaborator Author

zackcl commented Aug 14, 2024

Thank you, I resolved your comments regarding sorting (I reverted the last commit). I think that makes sense since selectSelectedFeatureFlag is called frequently. I just thought it would be cleaner to handle the sorting in one place.

Ideally, I think sorting shouldn't be necessary because it seems that the Postgres database already contains the feature_flag_segment_inclusion data in the correct order (when I execute SELECT * FROM "feature_flag_segment_inclusion";). However, the order seems different when we actually fetch the data from the backend. I'm not sure if this is expected behavior from Postgres or TypeORM. Here's the relevant issue I created: #1827

Please feel free to approve this PR.

@danoswaltCL danoswaltCL merged commit 9bde686 into dev Aug 14, 2024
8 checks passed
@danoswaltCL danoswaltCL deleted the feature/1754-exclude-list-row-actions branch August 14, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants