Feature/add list modal #1756
Merged
Feature/add list modal #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackcl
reviewed
Jul 12, 2024
frontend/projects/upgrade/src/app/core/feature-flags/store/feature-flags.model.ts
Show resolved
Hide resolved
zackcl
reviewed
Jul 12, 2024
frontend/projects/upgrade/src/app/shared/services/common-dialog.service.ts
Show resolved
Hide resolved
zackcl
reviewed
Jul 12, 2024
|
Comments resolved on this one. This one is not dependent on any backend changes, so it should be good to go now. |
Yagnik56
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial add-list-modal #1749
This creates the base modal and the type field to get this general modal started.
It also implements it for the
Add Include Listbutton.Eventually this modal is planned to be used for Add and Edit list flows in both the include / exclude flows.
You'll notice a few placeholder things, i tried to comment most places that are expected to need to change as we go.