-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FF: General Add List Modal #1749
Comments
hola, the design shows (
Couple thoughts:
or with double-quotes: |
Yeah, I like that! I can update the options to the following in Figma if @amurphy-cl confirms:
What I'm not totally sure about is how the group types are ordered. It looks like it's not alphabetical. Do you know how the order is determined? |
makes sense to be alphabetical, not sure why it wasn't previously |
I've updated the screenshot in the original post, where the "Group" is in alphabetical order:
|
@zackcl @amurphy-cl QA done for this. I dont see a decision made for the quotes around group names. But, I see that implemented in the code. Hope that's correct. Just one thing, I noticed that the segment names are not alphabetical, hope that's fine again, as we considered alphabetical order for the type dropdown. |
Yes, I believe both the segment and group names should appear in alphabetical order (ascending order). Also, the group type should be in this format:
|
Implement a modal that can be utilized for adding or editing lists for both Inclusion and Exclusion flows.
We should start with just the initial
type
selector, then other work can follow. Depending on the type selected, form will act differently, so we can start here and then develop the rest.Screenshot (Updated):
Considerations:
When the user opens this modal, we will only show a type selector at first. They can select:
The text was updated successfully, but these errors were encountered: