Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF: General Add List Modal #1749

Closed
danoswaltCL opened this issue Jul 10, 2024 · 6 comments · Fixed by #1756 or #1917
Closed

FF: General Add List Modal #1749

danoswaltCL opened this issue Jul 10, 2024 · 6 comments · Fixed by #1756 or #1917

Comments

@danoswaltCL
Copy link
Collaborator

danoswaltCL commented Jul 10, 2024

Implement a modal that can be utilized for adding or editing lists for both Inclusion and Exclusion flows.

We should start with just the initial type selector, then other work can follow. Depending on the type selected, form will act differently, so we can start here and then develop the rest.

Screenshot (Updated):

Feature Flag - Add Include List

Considerations:

  • This modal will need to be templated for use in both the Include and Exclude List functionality
  • This modal will need to be able to handle both Add and Edit functions

When the user opens this modal, we will only show a type selector at first. They can select:

  • Segment
  • Individual
  • Group (listed by each group type supported in that context)
@danoswaltCL
Copy link
Collaborator Author

danoswaltCL commented Jul 11, 2024

hola, the design shows (All won't be used now, ignore that):

Individual
Segment
groupId1 (group)
groupId2 (group)
groupId3 (group)

Image

Couple thoughts:

  1. Is this the preferred order from user perspective? Segment will probably be the most used thing right, can it be topmost?

Image

  1. While Zack was out I suggested a different format for how we show these groups [here] so they look more like the other options (https://carnegielearning.slack.com/archives/C02QA168MNW/p1718981331228129). That would be an app-wide change that can be implemented outside this later, but that would give us a list that looks like this for assign-prog. What do you think about that @zackcl

That would look like this:
Image

or with double-quotes:

Image

@amurphy-cl @bcb37

@danoswaltCL danoswaltCL moved this from Refined ToDo to Code Review in UpGrade Project Jul 11, 2024
@danoswaltCL danoswaltCL removed the status in UpGrade Project Jul 11, 2024
@zackcl
Copy link
Collaborator

zackcl commented Jul 12, 2024

Yeah, I like that! I can update the options to the following in Figma if @amurphy-cl confirms:

Segment
Individual
Group: schoolId
Group: classId
Group: instructorId

What I'm not totally sure about is how the group types are ordered. It looks like it's not alphabetical. Do you know how the order is determined?
Screenshot 2024-07-12 at 5 58 51 PM

@danoswaltCL danoswaltCL moved this to Code Review in UpGrade Project Jul 12, 2024
@amurphy-cl
Copy link
Collaborator

makes sense to be alphabetical, not sure why it wasn't previously

@zackcl
Copy link
Collaborator

zackcl commented Jul 15, 2024

I've updated the screenshot in the original post, where the "Group" is in alphabetical order:

Segment
Individual
Group: classId
Group: instructorId
Group: schoolId

@danoswaltCL danoswaltCL moved this from Code Review to Done in UpGrade Project Jul 16, 2024
@Yagnik56 Yagnik56 linked a pull request Jul 22, 2024 that will close this issue
@amurphy-cl amurphy-cl assigned ppratikcr7 and unassigned danoswaltCL Sep 3, 2024
@ppratikcr7
Copy link
Collaborator

@zackcl @amurphy-cl QA done for this. I dont see a decision made for the quotes around group names. But, I see that implemented in the code. Hope that's correct. Just one thing, I noticed that the segment names are not alphabetical, hope that's fine again, as we considered alphabetical order for the type dropdown.

Image
Image

@zackcl
Copy link
Collaborator

zackcl commented Sep 4, 2024

Yes, I believe both the segment and group names should appear in alphabetical order (ascending order). Also, the group type should be in this format: Group: groupId as we discussed without the quotes.

Segment
Individual
Group: classId
Group: instructorId
Group: schoolId

@zackcl zackcl moved this from QA to Refined ToDo in UpGrade Project Sep 4, 2024
@zackcl zackcl assigned zackcl and unassigned ppratikcr7 Sep 4, 2024
@zackcl zackcl moved this from Refined ToDo to In Progress in UpGrade Project Sep 10, 2024
@zackcl zackcl moved this from In Progress to Code Review in UpGrade Project Sep 10, 2024
@zackcl zackcl moved this from Code Review to QA in UpGrade Project Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment