-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common tag input component #1643
Conversation
standalone: true, | ||
providers: [ | ||
{ | ||
provide: NG_VALUE_ACCESSOR, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! thank you for taking the time to clean up the implementing code.
} | ||
|
||
// eslint-disable-next-line @typescript-eslint/no-empty-function | ||
registerOnTouched(fn: any) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this for? can it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ControlValueAccessor
interface mandates to implement its methods which includes registerOnTouched
. Currently there is no use for this so i've disabled it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, ty
...pp/shared-standalone-component-lib/components/common-tag-input/common-tag-input.component.ts
Show resolved
Hide resolved
* Using Tag input component in FF Add feature flag modal * Made tags as empty array in formbuilder. Removed required attribute from component
Component implements ControlValueAccessor to synchronize its value with the parent form control.