UI changes in Add Metrics page #1600

KD1712 · 2024-06-03T13:06:22Z

Replaced ID column with Context column, added context filter option. In ADD METRIC json-editor, added context list and removed highlighted blue line

…In ADD METRIC json-editor, added context list and removed highlighted blue line

KD1712 · 2024-06-03T13:34:21Z

@zackcl @danoswaltCL We are updating the UI of our table component, which includes a hierarchical tree structure. Initially, we used drop-down icons for all nodes. Now, changes made here to create difference between leaf node and expandable are: Expandable nodes use the drop-down icon and leaf nodes use bullet points (•).

Which design option do we prefer for representing leaf nodes in our table component:
Bullet Points OR Empty Space OR Disabled drop-down icon ?

ppratikcr7 · 2024-06-03T14:08:53Z

@zackcl @danoswaltCL We are updating the UI of our table component, which includes a hierarchical tree structure. Initially, we used drop-down icons for all nodes. Now, changes made here to create difference between leaf node and expandable are: Expandable nodes use the drop-down icon and leaf nodes use bullet points (•).

Which design option do we prefer for representing leaf nodes in our table component: Bullet Points OR Empty Space OR Disabled drop-down icon ?

@KD1712 Can you please add the reference image?

ppratikcr7

I found the following things in the UI:

The chips are not spaced as they should be in tags chips on experiment page.
The bullet points are square, can you make them round bullets? @zackcl What is your opinion on this?
The context chips when clicked, wont trigger search operation as we have on experiments page.
Can the alignment of the bullet point and arrow for different rows be more aligned in a straight line?

hsnee · 2024-06-03T14:37:41Z

FYI @zackcl is out until July 1st. Tagging @amurphy-cl to decide if someone else should have input on these.

amurphy-cl · 2024-06-03T17:43:57Z

Thanks Husni, @danoswaltCL can you have a look?

...de/src/app/features/dashboard/profile/components/modals/add-metrics/add-metrics.component.ts

ppratikcr7 · 2024-06-04T08:56:48Z

I found the following things in the UI:

The chips are not spaced as they should be in tags chips on experiment page.

The bullet points are square, can you make them round bullets? @zackcl What is your opinion on this?

The context chips when clicked, wont trigger search operation as we have on experiments page.

Can the alignment of the bullet point and arrow for different rows be more aligned in a straight line?

Adding one more thing, the context from dropdown on json editor is not saving metrics successfully, I guess that hook with backend is not implemented yet, and context might be needed in the JSON itself. I am using the below JSON to add new metrics:

{ "metrics": [ { "metric": "totalTimeSeconds3", "datatype": "continuous" } ] }

…t from select menu is attached to the Metric JSON on saving

KD1712 · 2024-06-05T14:21:23Z

@danoswaltCL We are updating the UI of our table component, which includes a hierarchical tree structure. Initially, we used drop-down icons for all nodes. Now, changes made here to create difference between leaf node and expandable are: Expandable nodes use the drop-down icon and leaf nodes use bullet points (•).
Which design option do we prefer for representing leaf nodes in our table component: Bullet Points OR Empty Space OR Disabled drop-down icon ?

@KD1712 Can you please add the reference image?

…into 1295-appContext-in-metrics

* Crud operation and store related changes for fetch feature flag paginated * added service changes and shifted some logic to selectors

* WIP: Feature flag admin endpoints * update feature flag service tests * review changes * merge dev into feature/feature-flag-admin-api * review changes --------- Co-authored-by: danoswaltCL <[email protected]>

ppratikcr7 · 2024-06-06T12:17:26Z

@KD1712 Thanks for adding a padding between the text and delete icon. I noticed one more thing, the delete icon is black and large in size, but we use a small and grey shade at all other places. Can you pick the css from design stepper page or profile page?

…into 1295-appContext-in-metrics

ppratikcr7 · 2024-06-11T09:36:56Z

@KD1712 I checked again, all looks good now. But, the delete button in the delete metrics modal is not enabled on correct metric path name. It is was working earlier and works in dev branch as well. Something is changed in this PR. Can you please check?

...projects/upgrade/src/app/core/experiment-design-stepper/experiment-design-stepper.service.ts

ppratikcr7

@KD1712 Have few comments, please check.

...projects/upgrade/src/app/core/experiment-design-stepper/experiment-design-stepper.service.ts

.../projects/upgrade/src/app/features/dashboard/profile/components/metrics/metrics.component.ts

ppratikcr7 · 2024-06-18T05:23:40Z

...de/src/app/features/dashboard/profile/components/modals/add-metrics/add-metrics.component.ts

 import { JsonEditorOptions, JsonEditorComponent } from 'ang-jsoneditor';
 import { MatDialogRef } from '@angular/material/dialog';
 import { AnalysisService } from '../../../../../../core/analysis/analysis.service';
+import { Subscription } from 'rxjs';
+// import { MetricUnit } from '../../../../../../core/analysis/store/analysis.models';


remove this commented import

...de/src/app/features/dashboard/profile/components/modals/add-metrics/add-metrics.component.ts

Replaced ID column with Context column, added context filter option. …

b6fc10a

…In ADD METRIC json-editor, added context list and removed highlighted blue line

KD1712 requested a review from ppratikcr7 June 3, 2024 13:06

KD1712 linked an issue Jun 3, 2024 that may be closed by this pull request

UI changes of metric page #1444

Closed

Merge branch 'dev' into 1295-appContext-in-metrics

3838043

ppratikcr7 requested a review from Yagnik56 June 3, 2024 13:19

ppratikcr7 assigned KD1712 Jun 3, 2024

ppratikcr7 requested changes Jun 3, 2024

View reviewed changes

RidhamShah reviewed Jun 4, 2024

View reviewed changes

...de/src/app/features/dashboard/profile/components/modals/add-metrics/add-metrics.component.ts Outdated Show resolved Hide resolved

Changed Table bullets to circle, aligned them. In ADD Metrics, contex…

99dd245

…t from select menu is attached to the Metric JSON on saving

KD1712 requested review from ppratikcr7 and RidhamShah June 5, 2024 14:18

KD1712 and others added 6 commits June 6, 2024 10:47

Disabled 'save' button in ADD metrics if Context is not selected

96a3671

Merge branch 'dev' of https://github.com/CarnegieLearningWeb/UpGrade …

b736f96

…into 1295-appContext-in-metrics

fetch feature flag paginated crud and store changes (#1541)

51022a5

* Crud operation and store related changes for fetch feature flag paginated * added service changes and shifted some logic to selectors

Feature flag admin endpoints (#1474)

127b445

* WIP: Feature flag admin endpoints * update feature flag service tests * review changes * merge dev into feature/feature-flag-admin-api * review changes --------- Co-authored-by: danoswaltCL <[email protected]>

Added margin to delete button in metrics table

db9287a

Duplicate enums error removed

63813ba

KD1712 and others added 2 commits June 7, 2024 10:54

Delete icon styling changed

2b6da0b

Merge branch 'dev' of https://github.com/CarnegieLearningWeb/UpGrade …

c7a8029

…into 1295-appContext-in-metrics

KD1712 added 2 commits June 12, 2024 14:59

Merge branch 'dev' into 1295-appContext-in-metrics

119e708

Resolved issue of disabled delete button in metric page delete modal

ce89cbd

danoswaltCL reviewed Jun 14, 2024

View reviewed changes

...projects/upgrade/src/app/core/experiment-design-stepper/experiment-design-stepper.service.ts Outdated Show resolved Hide resolved

ppratikcr7 requested changes Jun 18, 2024

View reviewed changes

Unintentional change revert. Resolved requested changes

1dbc444

KD1712 requested review from danoswaltCL and ppratikcr7 June 18, 2024 06:03

ppratikcr7 previously approved these changes Jun 18, 2024

View reviewed changes

Merge branch 'dev' into 1295-appContext-in-metrics

5a7576a

KD1712 dismissed ppratikcr7’s stale review via 5a7576a June 19, 2024 04:58

KD1712 requested a review from ppratikcr7 June 19, 2024 04:58

Conflict resolution

0a2cb9d

ppratikcr7 changed the title ~~UI changes in Metrics page~~ UI changes in Add Metrics page Jun 19, 2024

ppratikcr7 approved these changes Jun 19, 2024

View reviewed changes

ppratikcr7 merged commit 14d86b7 into dev Jun 19, 2024
8 checks passed

ppratikcr7 deleted the 1295-appContext-in-metrics branch June 19, 2024 05:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI changes in Add Metrics page #1600

UI changes in Add Metrics page #1600

KD1712 commented Jun 3, 2024

KD1712 commented Jun 3, 2024

ppratikcr7 commented Jun 3, 2024 •

edited

Loading

ppratikcr7 left a comment •

edited

Loading

hsnee commented Jun 3, 2024

amurphy-cl commented Jun 3, 2024

ppratikcr7 commented Jun 4, 2024

KD1712 commented Jun 5, 2024 •

edited

Loading

ppratikcr7 commented Jun 6, 2024 •

edited

Loading

ppratikcr7 commented Jun 11, 2024

ppratikcr7 left a comment

ppratikcr7 Jun 18, 2024

UI changes in Add Metrics page #1600

UI changes in Add Metrics page #1600

Conversation

KD1712 commented Jun 3, 2024

KD1712 commented Jun 3, 2024

ppratikcr7 commented Jun 3, 2024 • edited Loading

ppratikcr7 left a comment • edited Loading

Choose a reason for hiding this comment

hsnee commented Jun 3, 2024

amurphy-cl commented Jun 3, 2024

ppratikcr7 commented Jun 4, 2024

KD1712 commented Jun 5, 2024 • edited Loading

ppratikcr7 commented Jun 6, 2024 • edited Loading

ppratikcr7 commented Jun 11, 2024

ppratikcr7 left a comment

Choose a reason for hiding this comment

ppratikcr7 Jun 18, 2024

Choose a reason for hiding this comment

ppratikcr7 commented Jun 3, 2024 •

edited

Loading

ppratikcr7 left a comment •

edited

Loading

KD1712 commented Jun 5, 2024 •

edited

Loading

ppratikcr7 commented Jun 6, 2024 •

edited

Loading