Feature flag admin endpoints

[bcb37]

Adds (or updates) the following endpoints:

GET /flags

• get all feature flags

POST /flags

• create feature flag

GET /flags/{id}

• get flag by id

DELETE /flags/{id}

• delete flag by id

PUT /flags/{id}

• update flag by id

POST /flags/paginated

• get all flags paginated

POST /flags/status

• update flag status

The request (for POST and PUT) and response bodies for these endpoints can be viewed by looking at the swagger page.

[RidhamShah]

We also need FILTER_MODE (includeAll, excludeAll) in featureFlags for Segments logic too, as it is also present in Experiments.

if we don't want to use FILTER_MODE then we need to discuss how the Segments would work for it.

[bcb37]

We also need FILTER_MODE (includeAll, excludeAll) in featureFlags for Segments logic too, as it is also present in Experiments.

if we don't want to use FILTER_MODE then we need to discuss how the Segments would work for it.

@RidhamShah I've created a pr that adds FILTER_MODE to the db. When that's merged we can continue with this one.

[danoswaltCL]

what does inEx mean? inclusion / exclusion?

[bcb37]

Yeah, I'd meant to eventually give that a better name. Good catch

[danoswaltCL]

Line 240 says Experiments instead of Feature Flags

[danoswaltCL]

I asked copilot to pull this out 159-221 into own function without the repetition for the segment include and segment exclude. It needs some help with types but I thought something like this looked pretty reasonable, what do you think?

async function handleSegment(segmentInclusionExclusion: any, flagDoc: any, flag: any, type: string, logger: any) {

  let segmentExists = true;
  let segmentDoc: Segment;
  let segmentDocToSave: Partial<FeatureFlagSegmentInclusion | FeatureFlagSegmentExclusion> = {};
  if (segmentInclusionExclusion) {
    const segment: any = setSegmentInEx(segmentInclusionExclusion);

    const segmentData: SegmentInputValidator = {
      ...segment,
      id: segment.id || uuid(),
      name: flagDoc.id + ' ' + type + ' Segment',
      description: flagDoc.id + ' ' + type + ' Segment',
      context: flagDoc.context[0],
      type: SEGMENT_TYPE.PRIVATE,
    };
    try {
      segmentDoc = await this.segmentService.upsertSegment(segmentData, logger);
    } catch (err) {
      const error = err as ErrorWithType;
      error.details = 'Error in adding segment in DB';
      error.type = SERVER_ERROR.QUERY_FAILED;
      logger.error(error);
      throw error;
    }
    // creating segment doc
    const tempDoc = type === 'Inclusion' ? new FeatureFlagSegmentInclusion() : new FeatureFlagSegmentExclusion();
    tempDoc.segment = segmentDoc;
    tempDoc.featureFlag = flag;
    segmentDocToSave = this.getSegmentDoc(tempDoc);
  } else {
    segmentExists = false;
  }
  return { segmentExists, segmentDoc, segmentDocToSave };
}

[bcb37]

I think it makes sense to reduce duplication. I'll see what I can do about wrangling the types.

[danoswaltCL]

looks good to me, other than whatever's in the merge conflicts

[danoswaltCL]

hey it works. @VivekFitkariwala let us know if this can be merged, this will be helpful for getting the UI moving. I see some outstanding comments but I think Ben has responded.