ClientLib changes for featureFlags to getKeys #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VivekFitkariwala
previously approved these changes
May 27, 2024
…tConditionsRequestBody
VivekFitkariwala
changed the base branch from
feature/feature-flag-backend
to
dev
bcb37
reviewed
Jun 3, 2024
| experiment: ExperimentAssignmentValidator | ||
| ): Promise<string[]> { | ||
| const experimentUserDoc = await this.experimentUserService.getUserDoc(experiment.userId, request.logger); | ||
| return this.featureFlagService.getKeys(experimentUserDoc, experiment.context, request.logger); |
There was a problem hiding this comment.
We should return 404 when the user is not found, like with experiment assignment (and the removed 'keys' endpoint).
danoswaltCL
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this Pull Request, the ClientLib
getFeatureFlagsmethod invokesgetAllFeatureFlags, which returns an array of feature flags associated with the key user. ThegetFeatureFlagsmethod then returns true or false based on whether the specified feature-flag key is present in the array.