Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java library changes for feature flags #1341

Closed
amurphy-cl opened this issue Mar 5, 2024 · 2 comments · Fixed by #1585
Closed

Java library changes for feature flags #1341

amurphy-cl opened this issue Mar 5, 2024 · 2 comments · Fixed by #1585
Assignees
@kawcl
Labels
enhancement New feature or request epic: feature flags priority: high High priority issue release 6.0
Milestone
Program Increment...

Comments

@amurphy-cl
Copy link
Collaborator

amurphy-cl commented Mar 5, 2024 •
edited by danoswaltCL
Loading

Update Java client library's getAllFeaturedFlags and getFeatureFlag methods to call POST /featureflags.

Use the new structure for request / response as defined in #1340

getAllFeatureFlags will internally call POST /featureflags with a similar structure as getAllExperimentConditions(), with userId and context, and will store the list of key strings on the client.

getFeatureFlag should take a string and return true if the flags list contains that flag key, and false if it is not found.
@amurphy-cl amurphy-cl added the enhancement New feature or request label Mar 5, 2024
@amurphy-cl amurphy-cl changed the title Java library changes to feature flag API Java library changes for feature flags Mar 5, 2024
@amurphy-cl amurphy-cl mentioned this issue Mar 5, 2024
Closed
@amurphy-cl amurphy-cl moved this to Refined ToDo in UpGrade Project Mar 12, 2024
@RidhamShah RidhamShah self-assigned this May 26, 2024
@RidhamShah RidhamShah moved this from Refined ToDo to In Progress in UpGrade Project May 27, 2024
@RidhamShah RidhamShah linked a pull request May 27, 2024 that will close this issue
ClientLib changes for featureFlags to getKeys #1585
Merged
@RidhamShah RidhamShah moved this from In Progress to Code Review in UpGrade Project May 28, 2024
@amurphy-cl amurphy-cl added this to the Program Increment PI12 milestone Jun 4, 2024
@amurphy-cl amurphy-cl moved this from Code Review to Refined ToDo in UpGrade Project Jun 4, 2024
@RidhamShah RidhamShah moved this from Refined ToDo to QA in UpGrade Project Jun 24, 2024
@danoswaltCL
Copy link
Collaborator

This doesn't seem like it was done, reopening

@danoswaltCL danoswaltCL reopened this Aug 23, 2024
@github-project-automation github-project-automation bot moved this from QA to In Progress in UpGrade Project Aug 23, 2024
kawcl added a commit that referenced this issue Sep 19, 2024
@kawcl
#1341 update java client library feature flag methods
5b8441a
@kawcl kawcl moved this from Refined ToDo to Code Review in UpGrade Project Sep 20, 2024
@amurphy-cl
Copy link
Collaborator Author

Closing as done.

@amurphy-cl amurphy-cl moved this from Code Review to Done in UpGrade Project Oct 1, 2024
danoswaltCL added a commit that referenced this issue Oct 1, 2024
@kawcl @bcb37 @danoswaltCL
#1341 update java client library feature flag methods (#1968)
96c262e 
* 1341 update java client library feature flag methods

* 1341 update headers with userid, remove userid from requests

* add request beans that now differ from responses

---------

Co-authored-by: Benjamin Blanchard <[email protected]>
Co-authored-by: danoswaltCL <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kawcl kawcl

Labels
enhancement New feature or request epic: feature flags priority: high High priority issue release 6.0
Projects
UpGrade Project
Status: Done
Milestone
Program Increment PI13
Development

Successfully merging a pull request may close this issue.

ClientLib changes for featureFlags to getKeys CarnegieLearningWeb/UpGrade
4 participants
@RidhamShah @amurphy-cl @kawcl @danoswaltCL