Removed the terms and condition text on login page #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems like the right thing to do to me, @amurphy-cl thoughts on just removing the link? |
|
Yeah, I also think it's fine to remove it. Or maybe replace the text with something else like "To learn more about UpGrade, please visit www.upgradeplatform.org". Before:
After:
Demo App Login (For reference):
|
|
Linking to the website seems fine. |
|
@amurphy-cl I've added the new info message with a link to www.upgradeplatform.org. @danoswaltCL Feel free to review the change I made. 
|
VivekFitkariwala
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR terms and condition text on login page below Google sign in button has been removed as it looked like clickable link but didn't redirect any page and we don't have any term & conditions of our own as we are using google sign in only.