Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terms and Conditions Link is not clickable and Content for the same is not present #637

Closed
ppratikcr7 opened this issue Dec 1, 2022 · 1 comment · Fixed by #1487
Closed

Terms and Conditions Link is not clickable and Content for the same is not present #637

ppratikcr7 opened this issue Dec 1, 2022 · 1 comment · Fixed by #1487
Assignees
@Yagnik56
Labels
bug Something isn't working priority: low Low priority issue release 6.0

Comments

@ppratikcr7
Copy link
Collaborator

Describe the bug
On the Upgrade Login Page, the Terms and Conditions Link is not clickable and the content for the same is not present. Probably we should provide the terms and conditions page for this.

To Reproduce
Steps to reproduce the behavior:
Go to the main Upgrade portal login page. You can try clicking the Terms and Conditions Link.

Expected behavior
We should provide the terms and conditions page for this.

Screenshots
Screenshot 2022-11-24 at 2 40 24 PM
@ppratikcr7 ppratikcr7 added the bug Something isn't working label Dec 1, 2022
@mswartzCL mswartzCL moved this to Todo in UpGrade Project Dec 19, 2022
@danoswaltCL danoswaltCL removed the status in UpGrade Project Nov 3, 2023
@amurphy-cl amurphy-cl added the priority: low Low priority issue label Feb 6, 2024
@amurphy-cl
Copy link
Collaborator

Let's remove the text below the login button. Terms and conditions are basically the BSD-3 license, which aren't really relevant to using Google to login.

@amurphy-cl amurphy-cl moved this to Refined ToDo in UpGrade Project Feb 6, 2024
@Yagnik56 Yagnik56 self-assigned this Mar 26, 2024
@Yagnik56 Yagnik56 moved this from Refined ToDo to Code Review in UpGrade Project Apr 29, 2024
@Yagnik56 Yagnik56 linked a pull request May 1, 2024 that will close this issue
Removed the terms and condition text on login page #1487
Merged
@Yagnik56 Yagnik56 moved this from Code Review to QA in UpGrade Project May 10, 2024
@Yagnik56 Yagnik56 moved this from QA to Done in UpGrade Project May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yagnik56 Yagnik56

Labels
bug Something isn't working priority: low Low priority issue release 6.0
Projects
UpGrade Project
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed the terms and condition text on login page CarnegieLearningWeb/UpGrade
3 participants
@ppratikcr7 @Yagnik56 @amurphy-cl