-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist code changes in condition table when factor update #1376
Merged
bcb37
merged 9 commits into
dev
from
bugfix/persist-condition-payload-table-changes-after-editing-factors
Mar 20, 2024
+66
−24
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e209c47
Persist code changes in condition table which aren't related to facto…
Yagnik56 8f31716
Merge branch 'dev' into bugfix/persist-condition-payload-table-change…
Yagnik56 fdb81aa
Code clean up
Yagnik56 3f97e24
Merge branch 'dev' into bugfix/persist-condition-payload-table-change…
Yagnik56 95b670a
Merge branch 'dev' into bugfix/persist-condition-payload-table-change…
Yagnik56 8a9fd62
resolved issue of condition values not persisting while creating new …
Yagnik56 f8111ca
resolved review comment to remove isAnyRowRemoved
Yagnik56 508ee06
resolved review comment to remove isAnyRowRemoved in factorial design…
Yagnik56 21ad97b
Merge branch 'dev' into bugfix/persist-condition-payload-table-change…
Yagnik56 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need
isAnyRowRemoved
? I thinkisDesignDataValid
can replace it. And it doesn't go stale after multiple back-and-forth edits.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, I have run few test to check if it's working properly but it will be good if you can verify same.