Persist code changes in condition table when factor update #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-after-editing-factors
…s-after-editing-factors
bcb37
reviewed
Mar 18, 2024
...d/home/components/factorial-experiment-design/conditions-table/conditions-table.component.ts
Show resolved
Hide resolved
…s-after-editing-factors
bcb37
reviewed
Mar 19, 2024
| this.handleInitializeExistingTableData(); | ||
| } else if (!this.experimentInfo && this.formInitialized && !this.isAnyRowRemoved) { | ||
| } else if (!this.experimentInfo && !this.isAnyRowRemoved && (!this.formInitialized || !isDesignDataValid)) { |
There was a problem hiding this comment.
Do we still need isAnyRowRemoved? I think isDesignDataValid can replace it. And it doesn't go stale after multiple back-and-forth edits.
There was a problem hiding this comment.
done, I have run few test to check if it's working properly but it will be good if you can verify same.
bcb37
requested changes
Mar 20, 2024
|
Here you go @bcb37, you can QA and if works fine merge this PR. |
…s-after-editing-factors
bcb37
approved these changes
Mar 20, 2024
bcb37
deleted the
bugfix/persist-condition-payload-table-changes-after-editing-factors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will address issue of code changes not persisting in condition table when factor table get updated as we were generating new table for every edit. Now only rows which are related to code change in factor table will get updated.
Senario:
If we have 2 factors F1 and F2 and each have 2 levels L1,L2 and L3, L4
then when you change L4 to L5 condition not related L4 persist it's weightage and payload while new condition will be assigned 0 weight.
Users can edit values manually as they like or press equal weight to remove weight sum not equal 100 error.