Original url destinations like experiment detail page will not redirect to home after login #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry you to your original destination when clicking on a shared link
bcb37
reviewed
Nov 21, 2023
| user: null, | ||
| googleCredential: null, | ||
| redirectUrl: '/home', | ||
| }, |
There was a problem hiding this comment.
Do we need to set any attributes (besides redirectUrl) here, to test that they get set to the default values when clearState is called? The other two attributes in 'settings', for instance, aren't set here. If we do set them, it might be a more definitive test if they're initially set to different values.
There was a problem hiding this comment.
i updated the specs to make this a little more explicitly tested
bcb37
reviewed
Nov 21, 2023
| @@ -25,6 +32,13 @@ describe('clearState', () => { | |||
| toCheckAuth: null, | |||
| toFilterMetric: null, | |||
| }, | |||
| auth: { | |||
There was a problem hiding this comment.
Should the 'it' string read 'should reset settings and auth state...'?
bcb37
approved these changes
Nov 21, 2023
danoswaltCL
deleted the
feature/1137-shareable-urls-no-redirect-to-home
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1137
Most routes will redirect to
/homeif you click on a shared url such as an experiment detail page like/home/detail/abc123...because the original destination url gets lost after navigating to/login.This should allow one to open up a shared link, login if needed, and return to the intended destination page.