Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug (Enhancement?): Shared URLs should not always redirect to /home #1137

Closed
danoswaltCL opened this issue Nov 20, 2023 · 2 comments · Fixed by #1143
Closed

Bug (Enhancement?): Shared URLs should not always redirect to /home #1137

danoswaltCL opened this issue Nov 20, 2023 · 2 comments · Fixed by #1143
Assignees
@ppratikcr7 @danoswaltCL
Labels
bug Something isn't working release 5.1

Comments

@danoswaltCL
Copy link
Collaborator

danoswaltCL commented Nov 20, 2023 •
edited
Loading

We should be able to share and open up routed links, such as an experiment page.

Currently we always redirect to the /home page.

Current Behavior:

  1. Click into an experiment detail page, which will look like /home/detail/<experiment-id>.
  2. Copy that url
  3. Log out (or open up firefox or an ingognito tab that has no current session data for upgrade)
  4. Paste that url back into browser (as if you received this link from someone else but were not logged in)
  5. Log in

You will be redirected to /home.

Expected / Desiered behavior

  • The user should be navigated back to the page indicated by the original url, not /home.
@danoswaltCL danoswaltCL added the bug Something isn't working label Nov 20, 2023
@danoswaltCL danoswaltCL moved this to Todo in UpGrade Project Nov 20, 2023
@danoswaltCL danoswaltCL moved this from Todo to In Progress in UpGrade Project Nov 20, 2023
@danoswaltCL danoswaltCL self-assigned this Nov 20, 2023
@danoswaltCL danoswaltCL mentioned this issue Nov 21, 2023
Merged
@danoswaltCL danoswaltCL moved this from In Progress to QA in UpGrade Project Nov 21, 2023
@ppratikcr7 ppratikcr7 linked a pull request Nov 22, 2023 that will close this issue
Original url destinations like experiment detail page will not redirect to home after login #1143
Merged
@danoswaltCL
Copy link
Collaborator Author

QA: Pratik

@ppratikcr7
Copy link
Collaborator

QA: Done. Looks good.

@ppratikcr7 ppratikcr7 moved this from QA to Done in UpGrade Project Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppratikcr7 ppratikcr7

@danoswaltCL danoswaltCL

Labels
bug Something isn't working release 5.1
Projects
UpGrade Project
Status: Done
Milestone
No milestone
2 participants
@ppratikcr7 @danoswaltCL