Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix for archive state not working in QA testing #30 #1127

Merged
merged 1 commit into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions backend/packages/Upgrade/src/api/services/QueryService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,12 @@ export class QueryService {
const experiments: Experiment[] = [];

// checks for archieve state experiment
if (promiseResult[0].experiment?.state === EXPERIMENT_STATE.ARCHIVED) {
return this.getArchivedStats(queryIds, logger);
if (queryIds.length !== 0) {
if (promiseResult[0].experiment?.state === EXPERIMENT_STATE.ARCHIVED) {
return this.getArchivedStats(queryIds, logger);
}
} else {
return [];
}

const analyzePromise = promiseResult.map((query) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,6 @@ export class ExperimentStatusComponent implements OnInit {
}

setArchivedStatusAgreement() {
this.archivedStatusAgreement = true;
this.archivedStatusAgreement = !this.archivedStatusAgreement;
}
}
Loading