Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix for archive state not working in QA testing #30 #1127

Merged
merged 1 commit into from
Nov 16, 2023
Merged

🐛 Fix for archive state not working in QA testing #30 #1127

merged 1 commit into from
Nov 16, 2023

Conversation

ppratikcr7
Copy link
Collaborator

This PR contains the below fixes:

  1. Now, the Save button on the experiment status change modal will be disabled on unchecking the archived status confirmation checkbox again.
  2. Fixes the error when we used to change the experiment status to archived state. This was in case of experiments not containing any metric queries. So, handled that case for analyze() function.

@ppratikcr7 ppratikcr7 self-assigned this Nov 16, 2023
@ppratikcr7 ppratikcr7 linked an issue Nov 16, 2023 that may be closed by this pull request
Add Archive status for experiments #30
Closed
@ppratikcr7 ppratikcr7 mentioned this pull request Nov 16, 2023
Closed
@danoswaltCL danoswaltCL merged commit b5cb0be into dev Nov 16, 2023
8 checks passed
@danoswaltCL danoswaltCL deleted the feature/archive-status-backend-issue30 branch November 16, 2023 16:08
@danoswaltCL
Copy link
Collaborator

Re-QA: Zack

@zackcl
Copy link
Collaborator

zackcl commented Nov 20, 2023

QA: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danoswaltCL danoswaltCL danoswaltCL approved these changes

@bcb37 bcb37 Awaiting requested review from bcb37

@zackcl zackcl Awaiting requested review from zackcl

@RidhamShah RidhamShah Awaiting requested review from RidhamShah

Assignees

@ppratikcr7 ppratikcr7

Labels
bugfix small-pr
Projects
UpGrade Project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Archive status for experiments
3 participants
@ppratikcr7 @danoswaltCL @zackcl