Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6.0 Release #42

Merged
merged 5 commits into from
Jun 9, 2018
Merged

1.6.0 Release #42

merged 5 commits into from
Jun 9, 2018

Conversation

CalebMorris
Copy link
Owner

1.6.0 Release Notes

Behavior Changes

#40 moment.createFromInputFallback

Removed source implementation of moment.createFromInputFallback and allow the warning message, but prevent conflicts with other packages that need to implement this themselves. Originated from #35.

Issues Fixed

Dev Changes

#37 package-lock.json

Removed package-lock.
See #37 for my thoughts on why it shouldn't be present in a library.

#38 Remove call to deprecated Sinon stub API

Removes warning printed when running tests:

sinon.stub(obj, 'meth', fn) is deprecated and will be removed from the public API in a future version of sinon.
 Use stub(obj, 'meth').callsFake(fn).
 Codemod available at https://github.com/hurrymaplelad/sinon-codemod

See http://sinonjs.org/releases/v2.0.0/stubs/ for more information on Sinon stubbing.

#39 Travis Targets

  • Removed end-of-life node versions 0.x and 4.x
  • Added explicit test targets of 8.x and 9.x

Testing

The specific package logic behavior is mainly used for applications and
 provides not extra benefit being in the repo since it is not published.

The only real potential benefit and it is more a convenience. If a dev
 dependency suddenly causes a build failure I'll need to update the
 dependencies. This is something I should do regardless.
Added node 8 and 9 now that they have been officially released.
Removed 0.x and 5 as they are considered End-of-Life

https://github.com/nodejs/Release#nodejs-release-working-group
This allows consumers to choose how they wish to handle this behavior.
See #37 about removal. Already added to .gitignore, but forgot to remove this
@CalebMorris CalebMorris merged commit fe171c8 into master Jun 9, 2018
@CalebMorris CalebMorris deleted the dev-1.6.0 branch June 9, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant