Removed package-lock.json #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specific package logic behavior is mainly used for applications and provides not extra benefit being in the repo since it is not published. The only real potential benefit and it is more a convenience. If a dev dependency suddenly causes a build failure I'll need to update the dependencies. This is something I should do regardless.
CalebMorris
added a commit
that referenced
this pull request
Jun 9, 2018
See #37 about removal. Already added to .gitignore, but forgot to remove this
CalebMorris
added a commit
that referenced
this pull request
Jun 9, 2018
See #37 about removal. Already added to .gitignore, but forgot to remove this
Merged
CalebMorris
added a commit
that referenced
this pull request
Jun 9, 2018
See #37 about removal. Already added to .gitignore, but forgot to remove this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specific package logic behavior is mainly used for applications and
provides not extra benefit being in the repo since it is not published.
The only real potential benefit and it is more a convenience. If a dev
dependency suddenly causes a build failure I'll need to update the
dependencies. This is something I should do regardless.