Keep times of animated sprites in sync #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMS212
added a commit
to IMS212/sodium-fabric
that referenced
this pull request
Aug 6, 2024
…-sync Keep times of animated sprites in sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR largely fixes #1479, it is just a modernized version of FlashyReese@68b0e0d.
Note: there is still a minor issue where since the sprite is not uploaded again till the start of the next frame, it might be desynced from other animated sprites on the initial frame where it becomes active. Addressing this would probably be more complex and so I deemed it out of scope of the PR.