fix: add hitboxes inside some voxelshapes of cuboids #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds collision boxes inside some blocks (e.g. extended piston base, daylight sensors) as they are in vanilla.
This fixes: Lithium removes hitboxes inside some blocks. #60
The bug was caused by lithium not implementing the weird behavior from vanilla, where SimpleVoxelShapes with BitSetVoxelSets behave as if they have a hitbox at every 1/8th or 1/4th of a block inside them.
The problem is solved by adding a new VoxelShapeCuboidWithCollisionBoxesInside extends VoxelShapeSimpleCube that mimicks the behavior from vanilla. The overwritten VoxelShapes.cuboid(Box box) method now decides whether a VoxelShapeSimpleCube can be used or the more complex VoxelShapeCuboidWithCollisionBoxesInside needs to be used, by testing whether vanilla would create a shape with extra hitboxes inside. This probably costs some runtime, so benchmarks need to be done.