Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lithium removes hitboxes inside some blocks. #60

Closed
2No2Name opened this issue Jun 24, 2020 · 1 comment
Closed

Lithium removes hitboxes inside some blocks. #60

2No2Name opened this issue Jun 24, 2020 · 1 comment
Labels
A-vanilla-parity Area: Vanilla Parity S-confirmed Status: Confirmed T-bug Type: Bug

Comments

@2No2Name
Copy link
Member

Expected Behavior

Lithium should not change any block hitboxes.

Actual Behavior

Lithium has fewer hitboxes than vanilla, e.g. inside extended piston bases or daylight sensors.

Reproduction Steps

Build this contraption (using soul sand, and setblock the piston then)
In Vanilla the outcome is a) while in Lithium the outcome is b).

Analysis

It is caused by Lithium replacing the cuboid method that creates VoxelShapes. In vanilla sometimes VoxelShapes with a BitSet are created. They have a collision box at every bit border (8th or 4th of a block) that is inside the cuboid. Lithium does not have those collision boxes inside the cuboid.
Disabling shapes.specialized_shapes works around the issue.

Attachments

a) https://cdn.discordapp.com/attachments/648967810139029505/724030415480029284/2020-06-21_00.38.00.png
b) https://cdn.discordapp.com/attachments/648967810139029505/724030982176374956/2020-06-21_00.40.32.png
@2No2Name 2No2Name added the T-bug Type: Bug label Jun 24, 2020
@jellysquid3 jellysquid3 added S-confirmed Status: Confirmed A-vanilla-parity Area: Vanilla Parity labels Jun 24, 2020
2No2Name added a commit to 2No2Name/lithium-fabric that referenced this issue Jul 9, 2020
@2No2Name
fix: add hitboxes inside some voxelshapes of cuboids (e.g. extended p…
2d47884 
…iston base)

fixes: Entities within EPSILON of a block will not move backwards
fixes: Lithium removes hitboxes inside some blocks. CaffeineMC#60
2No2Name added a commit to 2No2Name/lithium-fabric that referenced this issue Jul 12, 2020
@2No2Name
fix: add hitboxes inside some voxelshapes of cuboids (e.g. extended p…
c26d1fa 
…iston base)

fixes: Lithium removes hitboxes inside some blocks. CaffeineMC#60
@2No2Name 2No2Name mentioned this issue Jul 12, 2020
Merged
2No2Name added a commit to 2No2Name/lithium-fabric that referenced this issue Jul 13, 2020
@2No2Name
fix: add hitboxes inside some voxelshapes of cuboids (e.g. extended p…
d322ab6 
…iston base)

fixes: Lithium removes hitboxes inside some blocks. CaffeineMC#60

squashed: fix small mistakes and improve bad comments
@2No2Name
Copy link
Member Author

2No2Name commented Aug 6, 2020

Fixed in 0abafdf

@2No2Name 2No2Name closed this as completed Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-vanilla-parity Area: Vanilla Parity S-confirmed Status: Confirmed T-bug Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jellysquid3 @2No2Name