Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TagImplMixin breaks hotswap because its target does not exist #77

Merged

Conversation

2No2Name
Copy link
Member

@2No2Name 2No2Name commented Jul 6, 2020

TagImpl$1 seems to have moved to SetTag, but the Mixin wasn't changed. This PR changes the mixin so that it is properly applied to SetTag.

This was also causing hotswap to break, which works now again.

Copy link
Member

@jellysquid3 jellysquid3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jellysquid3 jellysquid3 merged commit d45536a into CaffeineMC:1.16.x/dev Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants