fix: TagImplMixin breaks hotswap because its target does not exist (#77)

CaffeineMC · Jul 6, 2020 · d45536a · d45536a
1 parent 76371c3
commit d45536a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/.../mods/lithium/mixin/tag/TagImplMixin.java → ...d/mods/lithium/mixin/tag/SetTagMixin.java b/.../mods/lithium/mixin/tag/TagImplMixin.java → ...d/mods/lithium/mixin/tag/SetTagMixin.java
@@ -3,21 +3,22 @@
 import com.google.common.collect.ImmutableList;
 import it.unimi.dsi.fastutil.objects.ReferenceArraySet;
 import it.unimi.dsi.fastutil.objects.ReferenceOpenHashSet;
+import net.minecraft.tag.SetTag;
 import net.minecraft.tag.Tag;
+import org.spongepowered.asm.mixin.Final;
 import org.spongepowered.asm.mixin.Mixin;
+import org.spongepowered.asm.mixin.Mutable;
 import org.spongepowered.asm.mixin.Shadow;
 import org.spongepowered.asm.mixin.injection.At;
 import org.spongepowered.asm.mixin.injection.Inject;
 import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
 
 import java.util.Set;
 
-@Mixin(targets = "net/minecraft/tag/Tag$1")
-public abstract class TagImplMixin<T> implements Tag<T> {
-    // Synthetic field -- plugin cannot see it
-    @SuppressWarnings("ShadowTarget")
-    @Shadow(remap = false)
-    private Set<T> field_23686;
+@Mixin(SetTag.class)
+public abstract class SetTagMixin<T> implements Tag<T> {
+    @Shadow @Final @Mutable
+    private Set<T> field_25594;
 
     /**
      * If the number of elements in a tag is very small (<=3), it can be significantly faster to use simple linear scanning
@@ -29,15 +30,14 @@ public abstract class TagImplMixin<T> implements Tag<T> {
      * @author JellySquid
      */
     // Plugin has trouble seeing this, but it exists
-    @SuppressWarnings("UnresolvedMixinReference")
-    @Inject(method = "<init>(Ljava/util/Set;Lcom/google/common/collect/ImmutableList;)V", at = @At("RETURN"))
-    private void init(Set<T> set, ImmutableList<T> list, CallbackInfo ci) {
+    @Inject(method = "<init>(Ljava/util/Set;Ljava/lang/Class;)V", at = @At("RETURN"))
+    private void init(Set<T> set, Class<?> var2, CallbackInfo ci) {
         // Reference equality is safe for tag values
         // Use linear-scanning when the number of items in the tag is small
-        if (this.field_23686.size() <= 3) {
-            this.field_23686 = new ReferenceArraySet<>(this.field_23686);
+        if (this.field_25594.size() <= 3) {
+            this.field_25594 = new ReferenceArraySet<>(this.field_25594);
         } else {
-            this.field_23686 = new ReferenceOpenHashSet<>(this.field_23686);
+            this.field_25594 = new ReferenceOpenHashSet<>(this.field_25594);
         }
     }
 }
diff --git a/src/main/resources/lithium.mixins.json b/src/main/resources/lithium.mixins.json
@@ -76,7 +76,7 @@
         "shapes.shape_merging.VoxelShapesMixin",
         "shapes.specialized_shapes.VoxelShapeMixin",
         "shapes.specialized_shapes.VoxelShapesMixin",
-        "tag.TagImplMixin",
+        "tag.SetTagMixin",
         "world.chunk_access.ChunkHolderMixin",
         "world.chunk_access.ServerChunkManagerMixin",
         "world.chunk_access.WorldMixin",