fix: stacked tnt explode at the wrong height #66 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 1.16 snapshots Mojang added a distinction between TNT and other entities in the explosion code to fix the the increased eye height affecting explosions. The eye height increase was an attempt to fix rendering of tnt on soulsand.
This pullrequest adds the behavior to lithium, which is necessary as lithium overwrites the minecraft explosion code.
Thanks to @pwouik for reporting #66 .
Here is a testworld for this (summon stacked tnt on a clock, with pauses in between).
lithium #66.zip