Add tests in conjunction with fix for issue #1045 in cadasta-platform #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shailysangwan
commented
Feb 28, 2017
| action.send_keys(Keys.TAB).send_keys(Keys.RETURN).perform() | ||
|
|
||
| text = self.wd.find_elements_by_xpath("//ul[contains(@class, 'parsley-errors-list')]") | ||
| assert len(text) == 1 |
There was a problem hiding this comment.
Expecting only one error after the fix
|
@manoramahp Would you be able to review this PR and merge it in if you think it's good to go? You're closest to the code base at the moment so I think you the best person for this. |
|
@shailysangwan, @oliverroick This PR looks good. Hence merged. |
|
@shailysangwan Thank you for this PR. You can add these two test cases here in the cadasta-test wiki, so that any contributor get to know what are the already implemented test cases. |
|
@manoramahp I had tried doing that, but I guess I don't have the permissions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in https://github.com/Cadasta/cadasta-project-ideas/issues/17, I have added the tests as part of the fix for Cadasta/cadasta-platform#1045, to go along with PR Cadasta/cadasta-platform#1134.