Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect password validation error #1045

Closed
bjohare opened this issue Jan 11, 2017 · 2 comments · Fixed by #1134
Closed

Incorrect password validation error #1045

bjohare opened this issue Jan 11, 2017 · 2 comments · Fixed by #1134
Assignees
@clash99
Labels
bug First Contribution Friendly priority: medium

Comments

@bjohare
Copy link
Contributor

bjohare commented Jan 11, 2017

Steps to reproduce the error

Navigate to the account registration page at https://platform-staging.cadasta.org/account/signup/. Enter a username, password, confirm password and full name. Leave the email field blank. Click 'Register'. The email validation error is displayed correctly but an incorrect password validation error message is displayed: 'Your password cannot contain your email mailbox name.' The passwords were generated by LastPass and don't contain any reference to an email mailbox.

password

Actual behavior

An incorrect password validation error is displayed.

Expected behavior

I wouldn't expect a password validation error when a blank email field is provided.
@bjohare bjohare added the bug label Jan 11, 2017
@dpalomino
Copy link

We will revisit this when implementing the password strength validation.

@bjohare
Copy link
Contributor Author

bjohare commented Feb 7, 2017

Guessing this is the same issue?
pw_validation

This was referenced Feb 16, 2017
Closed
Merged
amplifi pushed a commit that referenced this issue Feb 27, 2017
@shailysangwan @amplifi
Fix #1045: Remove incorrect password validation error (#1134)
813e9eb 
* Remove incorrect password validation error in forms.py

Fix #1045

* Remove incorrect password validation error in serializers.py

Fix #1045

* Remove incorrect password validation error in validators.py

Fix #1045

* Remove incorrect password validation error in parsleyAddValidator.js

Fix #1045

* Add forms tests for incorrect password validation error

* Add serializer tests for incorrect password validation error

* Removed unnecessary console.log statement
@shailysangwan shailysangwan mentioned this issue Feb 28, 2017
Merged
oliverroick pushed a commit that referenced this issue Mar 17, 2017
@valaparthvi @oliverroick
Fixes #1045: Case Insensitive username and password comparison (#1149)
5c05510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clash99 clash99

Labels
bug First Contribution Friendly priority: medium
Projects
None yet
Milestone
No milestone
3 participants
@clash99 @bjohare @dpalomino