Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user-based UI element visibility issues #499

Merged
merged 2 commits into from
Jul 25, 2016

Conversation

ian-ross
Copy link
Contributor

Fix 183: project page ellipsis menu visibility
Fix 184: add project organisation filtering
Fix 185: display of project add button

(Some of the code added here will be cleaned up and rationalised as part of #485.)

@@ -472,6 +489,7 @@ def test_full_flow_valid(self):
reverse('project:add'), self.DETAILS_POST_DATA
)
assert details_response.status_code == 200
print(details_response)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove print statements.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should, but sometimes we forget...

@oliverroick
Copy link
Member

@ian-ross
Copy link
Contributor Author

All fair comments. I'll fix these things. I'd not thought about doing the organization dashboard as well, but it's definitely in scope for this.

@ian-ross ian-ross force-pushed the bugfix/ui-visibility-fixes branch 4 times, most recently from bab200d to ed73e4c Compare July 22, 2016 19:41
@ian-ross
Copy link
Contributor Author

Some of this isn't very pretty. I've been experimenting with a couple of different approaches to doing these "pre-request" permissions checks. I'm planning to consolidate and clean this stuff up when I do #485.

Fix 183: project page ellipsis menu visibility
Fix 184: add project organisation filtering
Fix 185: display of project add button

Also does the same sort of things for organization pages...
@ian-ross ian-ross force-pushed the bugfix/ui-visibility-fixes branch from ed73e4c to 42639a9 Compare July 25, 2016 05:46
@oliverroick oliverroick merged commit 429ee1c into master Jul 25, 2016
@oliverroick oliverroick deleted the bugfix/ui-visibility-fixes branch July 25, 2016 10:05
@seav seav mentioned this pull request Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants