-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix user-based UI element visibility issues #499
Conversation
@@ -472,6 +489,7 @@ def test_full_flow_valid(self): | |||
reverse('project:add'), self.DETAILS_POST_DATA | |||
) | |||
assert details_response.status_code == 200 | |||
print(details_response) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove print
statements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should, but sometimes we forget...
|
All fair comments. I'll fix these things. I'd not thought about doing the organization dashboard as well, but it's definitely in scope for this. |
bab200d
to
ed73e4c
Compare
Some of this isn't very pretty. I've been experimenting with a couple of different approaches to doing these "pre-request" permissions checks. I'm planning to consolidate and clean this stuff up when I do #485. |
Fix 183: project page ellipsis menu visibility Fix 184: add project organisation filtering Fix 185: display of project add button Also does the same sort of things for organization pages...
ed73e4c
to
42639a9
Compare
Fix 183: project page ellipsis menu visibility
Fix 184: add project organisation filtering
Fix 185: display of project add button
(Some of the code added here will be cleaned up and rationalised as part of #485.)