Prefill the resource name field with the filename

[niharika1995]

Proposed changes in this pull request

Fixes #1392

When should this PR be merged

Anytime.

Risks

None

Follow-up actions

• Collect static.

Checklist (for reviewing)

General

• Is this PR explained thoroughly? All code changes must be accounted for in the PR description.
• Is the PR labeled correctly? It should have the migration label if a new migration is added.
• Is the risk level assessment sufficient? The risks section should contain all risks that might be introduced with the PR and which actions we need to take to mitigate these risks. Possible risks are database migrations, new libraries that need to be installed or changes to deployment scripts.

Functionality

• Are all requirements met? Compare implemented functionality with the requirements specification.
• Does the UI work as expected? There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.

Code

• Do you fully understand the introduced changes to the code? If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.
• Does the PR introduce any inefficient database requests? Use the debug server to check for duplicate requests.
• Are all necessary strings marked for translation? All strings that are exposed to users via the UI must be marked for translation.

Tests

• Are there sufficient test cases? Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.
• If this is a bug fix, are tests for the issue in place? There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.
• If this is a new feature or a significant change to an existing feature? has the manual testing spreadsheet been updated with instructions for manual testing?

Security

• Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
• Are all UI and API inputs run through forms or serializers?
• Are all external inputs validated and sanitized appropriately?
• Does all branching logic have a default case?
• Does this solution handle outliers and edge cases gracefully?
• Are all external communications secured and restricted to SSL?

Documentation

• Are changes to the UI documented in the platform docs? If this PR introduces new platform site functionality or changes existing ones, the changes must be documented in the Cadasta Platform Documentation.
• Are changes to the API documented in the API docs? If this PR introduces new API functionality or changes existing ones, the changes must be documented in the API docs.
• Are reusable components documented? If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.

[niharika1995]

@seav Is the current simple implementation good enough or would you prefer using this function

[niharika1995]

ping.

[oliverroick]

@niharika1995 We are currently reviewing and merging other PR which fix higher priority issues. We will get to this PR soon.

[bjohare]

@niharika1995 thanks for your contribution. The file-upload.js script is currently used in three places in the platform:

• ProjectAddDetails form in the project creation wizard.
• ProjectEditDetails form in the project creation wizard.
• ResourceForm in the resources app.
  We need to restrict this functionality to Resource uploads only. In the Project Wizard the user can upload a questionnaire. If the user is editing a project and uploads a questionnaire the project name will be replaced with the questionnaire name. Adding a new Project is not affected as the name field is called details-name. One possible approach would be to inspect the value of window.location.href and if it ends with /resources/add/new then go ahead and update the name field.

[niharika1995]

@bjohare Please review. I addressed the issue you raised.

[bjohare]

Thanks @niharika1995 this looks good. You should rebase onto our latest master. We'll try to merge this once @oliverroick has had a chance to review.

[oliverroick]

Looks good thanks!