Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating draft DOI for folder when folder is published #257

Merged
merged 20 commits into from
Nov 2, 2021

Conversation

csc-jm
Copy link
Collaborator

@csc-jm csc-jm commented Sep 3, 2021

Description

This PR enables requesting DataCite REST API and creating a draft DOI for a folder when the folder is published via publish_folder endpoint. PR also includes a mock DOI app, that is meant to resemble the response from DataCite REST API.

Further development is required for full functionality to complete the DOI creation workflow.

Related issues

Partially fixes #155

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Changes Made

  • added a doi helper class which can request a draft DOI creation from DataCite API
  • altered publish_folder endpoint so that extraInfo containing the DOI data is added upon publishing
  • added datePublished key to folders which takes in the date/time, when folder is published
  • created a mock web app, which would act similarly to DataCite REST API
  • added configuration values, and the mock app to docker compose file
  • added unit test class for DOIHandler and altered integration tests to work with no feature

Testing

  • Unit Tests
  • Integration Tests

Mentions

The DOIHandler was composed similarly to SDA-orchestrator

@csc-jm csc-jm added the enhancement New feature or request label Sep 3, 2021
@csc-jm csc-jm force-pushed the feature/get-doi-for-folder branch from 21e2569 to 803d647 Compare September 3, 2021 11:11
tests/integration/run_tests.py Outdated Show resolved Hide resolved
@csc-jm csc-jm requested a review from blankdots September 3, 2021 11:23
@csc-jm csc-jm marked this pull request as ready for review September 3, 2021 11:23
@blankdots blankdots linked an issue Sep 29, 2021 that may be closed by this pull request
@blankdots blankdots force-pushed the feature/get-doi-for-folder branch 2 times, most recently from 0fd3c8b to 05a381d Compare October 6, 2021 06:59
@blankdots blankdots force-pushed the feature/get-doi-for-folder branch from a687c80 to 1bdb706 Compare November 1, 2021 07:28
@blankdots blankdots force-pushed the feature/get-doi-for-folder branch from 1bdb706 to 562388c Compare November 2, 2021 09:15
@blankdots
Copy link
Contributor

publishing a real DOI, will come in a follow-up PR

@blankdots blankdots merged commit eb810f4 into develop Nov 2, 2021
@blankdots blankdots deleted the feature/get-doi-for-folder branch November 2, 2021 10:15
@blankdots blankdots mentioned this pull request Nov 5, 2021
2 tasks
@blankdots blankdots mentioned this pull request Apr 7, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get DOI for folder when published
3 participants