-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating draft DOI for folder when folder is published #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csc-jm
force-pushed
the
feature/get-doi-for-folder
branch
from
September 3, 2021 11:11
21e2569
to
803d647
Compare
csc-jm
commented
Sep 3, 2021
blankdots
force-pushed
the
feature/get-doi-for-folder
branch
2 times, most recently
from
October 6, 2021 06:59
0fd3c8b
to
05a381d
Compare
blankdots
force-pushed
the
feature/get-doi-for-folder
branch
from
November 1, 2021 07:28
a687c80
to
1bdb706
Compare
remove null from doi schema
adjust folder datacite info to schema
blankdots
force-pushed
the
feature/get-doi-for-folder
branch
from
November 2, 2021 09:15
1bdb706
to
562388c
Compare
publishing a real DOI, will come in a follow-up PR |
teemukataja
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables requesting DataCite REST API and creating a draft DOI for a folder when the folder is published via
publish_folder
endpoint. PR also includes a mock DOI app, that is meant to resemble the response from DataCite REST API.Further development is required for full functionality to complete the DOI creation workflow.
Related issues
Partially fixes #155
Type of change
Changes Made
publish_folder
endpoint so thatextraInfo
containing the DOI data is added upon publishingdatePublished
key to folders which takes in the date/time, when folder is publishedDOIHandler
and altered integration tests to work with no featureTesting
Mentions
The DOIHandler was composed similarly to SDA-orchestrator