Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/finalize wizard #64

Merged
merged 31 commits into from
Aug 13, 2020
Merged

Feature/finalize wizard #64

merged 31 commits into from
Aug 13, 2020

Conversation

otahontas
Copy link
Contributor

Description

This PR finalizes the wizard layout, adding proper functionality for creating a folder and adding objects inside it.

Related issues

Fixes #28 and #30

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Changes Made

  • Added folder support: Folders are posted to backend and added to redux store when clicking next in first wizard step. Folder-form is locked / disabled after creating folder.
  • Added support for adding objects to folders: when new xml / form based object is submitted succesfully to backend, it is also added to folder in backend and redux store
  • Added support for summary of metadata objects
  • Added support for object adding layout with accordion
  • Added possibility to clear forms
  • Added alert when user exists form
  • Added alert when user cancels wizard. If user wants to cancel, folder and all of its contents are deleted from backend
  • Couple of other bugfixes, see git log

Testing

  • Needs testing

otahontas added 30 commits August 11, 2020 14:22
@otahontas
Remove breaking objectypeslice tests
129263c
@otahontas
Remove unnecessary complexity from object type redux settings
8181012
@otahontas
Add api methods for folder operations, fix some api type hints
2628e07
@otahontas
POST folder to backend when creating, add it to redux state
bec5cfd
@otahontas
Add folderreducer to global reducer
3e4d6b1
@otahontas
Add hot reloading for redux state
bfe96d9
@otahontas
Add support for adding objects to folder in redux
c5ac70c
@otahontas
Add initial support for showing folder content to user
ae82c99
@otahontas
Patch submissions to folders after succesful add in frontend
fc4a2f1
@otahontas
Fix bug where booleans got casted to numbers before submitting
c9bfb37
@otahontas
Add objects to folders after submitting them via form
019077f
@otahontas
Add summary to wizard
419c2d9
@otahontas
Add type hints to summaryarray
b5ca5b2
@otahontas
Set next to be disabled on last wizard step
e568aa6
@otahontas
Disable folder form if folder is present in store
ee16bca 
Returning "fake" disable form here is a bit hacky solution, better one would be to disable Formik form.
@otahontas
Set correct responsibilities for footer buttons
ff63b1c 
Cancel now clears all wizard-related states to their initial status,
save+exit and publish are disabled when they should be disabled.
@otahontas
Add dialog for checking if user really wants to cancel
50155dc
@otahontas
Delete folder and its content when users cancels the wizard
f61632f
@otahontas
Fix bugs with adding objects to folders
147a08c
@otahontas
Add better spacing for summary fields
0067b7b
@otahontas
Fix tabs with accordion
9e94993
@otahontas
Add submissiontype list under accordions
ee9bff9
@otahontas
Prepare objectaddcard for taking submissiontype from store
66ef7c7
@otahontas
Add reducer for submissionType
5a48c08
@otahontas
Set addobjectcard to render correct component
3e5350a
@otahontas
Reset also submissiontype when hiding form
5eb3356
@otahontas
Fix bug where valid schema was requested again from backend
fedc428
@otahontas
Fix form layout bugs
0234ae8
@otahontas
Show currently checked object type
543296d
@otahontas
Add possibility to clear forms
984c0b2
@otahontas otahontas self-assigned this Aug 13, 2020
@otahontas otahontas merged commit 4c407d5 into develop Aug 13, 2020
@otahontas otahontas deleted the feature/finalize-wizard branch August 13, 2020 13:48
@otahontas otahontas mentioned this pull request Aug 13, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blankdots blankdots blankdots approved these changes

@csc-jm-zz csc-jm-zz Awaiting requested review from csc-jm-zz

Assignees

@otahontas otahontas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@otahontas @blankdots