Feature/add oneOf rendering #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blankdots
reviewed
Aug 10, 2020
There was a problem hiding this comment.
Noticed
and made a PR with more typo fixes: CSCfi/metadata-submitter#117
There are actually a few different keys without any titles, which should be fixed at some point. See for example https://github.com/CSCfi/metadata-submitter/blob/950555f0b7309fbd4379dc0bbfbf4f13ae96187d/metadata_backend/helpers/schemas/ena_experiment.json#L364 Currently version is to render path of field (such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for oneOf-fields: user can select which option he/she wants to use and correct fields are rendering according to selection. Layout issues such as save-button positioning and headings for arrays are also fixed.
Related issues
Fixes #42, #55
Type of change
Testing