Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OneOf -type rendering and validation #42

Closed
otahontas opened this issue Aug 3, 2020 · 0 comments
Closed

Fix OneOf -type rendering and validation #42

otahontas opened this issue Aug 3, 2020 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@otahontas
Copy link
Contributor

otahontas commented Aug 3, 2020

Describe the bug

Our form rendeder and Yup-schema builder dont' currently work well with oneOf -schema keywords. For this problem, we could follow react-jsonschema-forms approach where each option of OneOf -array are presented as select field, and after user has selected one option, that option is rendered. Look for "Policy URL / policy text" in policy schema for example

Following changes should be made:

  • Optional form field rendering based on user select, see formik docs for dependent fields and array-based rendering
  • Custom config to yup schema, where oneOf types are better recognized

To Reproduce

Steps to reproduce the behaviour:

  1. open fill form option for either run, experiment, analysis or policy
  2. Form renders, but only partially. See console for errors.

Expected behavior

Form renders without problems

@otahontas otahontas added the bug Something isn't working label Aug 3, 2020
@otahontas otahontas self-assigned this Aug 3, 2020
@otahontas otahontas mentioned this issue Aug 13, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant