Handle required form arrays

[saulipurhonen]

Description

Submitting forms that contain required form array fields caused server errors if these fields were invalid.

Related issues

Closes #477 & #480

Type of change

• Bug fix (non-breaking change which fixes an issue)

Changes Made

• Register a hidden input for required form arrays
• Display error for invalid field
• Clear error on appending form array

Testing

• Integration Tests

[hannyle]

Great! The problem is fixed!

[hannyle]

One minor thing is for Run form > Experiment Reference, when we Add new item but doesn't fill in anything, Submit the form still links to server error because there is no required field within Experiment Reference.

I remember we have fixed this kind of problem a while ago but for some reason it still exists here. Could we solve it in this PR or should we fix it in another one ?

[saulipurhonen]

One minor thing is for Run form > Experiment Reference, when we Add new item but doesn't fill in anything, Submit the form still links to server error because there is no required field within Experiment Reference.

I remember we have fixed this kind of problem a while ago but for some reason it still exists here. Could we solve it in this PR or should we fix it in another one ?

I also remember that this was fixed. Weird thing is that it seems that this error exists also in develop -branch.
If I recall correctly, we fixed it by forcing the first field of array to be required.
I'll take a look into this and see if I could add some minor change into this branch.

[saulipurhonen]

One minor thing is for Run form > Experiment Reference, when we Add new item but doesn't fill in anything, Submit the form still links to server error because there is no required field within Experiment Reference.
I remember we have fixed this kind of problem a while ago but for some reason it still exists here. Could we solve it in this PR or should we fix it in another one ?

I also remember that this was fixed. Weird thing is that it seems that this error exists also in develop -branch. If I recall correctly, we fixed it by forcing the first field of array to be required. I'll take a look into this and see if I could add some minor change into this branch.

Introduced a possible fix.

[hannyle]

Looks good to me!

[blankdots]

tested and looks good.

For the DAC ( i suspect for the others as well) if the fields are not filled correctly it just complains a item is needed. If there is a quick way to fix it I suggest we make a note of it and fix it as part of #429 or some other issue

I assume it will be addressed as a JSON/form validation error and can come from front-end or backend.

[blankdots]

feel free to merge, if my comment is not addressed as part of this.

[saulipurhonen]

tested and looks good.

For the DAC ( i suspect for the others as well) if the fields are not filled correctly it just complains a item is needed. If there is a quick way to fix it I suggest we make a note of it and fix it as part of #429 or some other issue ![Peek 2021-10-13 12-01]

I assume it will be addressed as a JSON/form validation error and can come from front-end or backend.

This problem seems to be part of bigger issue. I tested this on develop branch and we don't get a helper text for invalid Contact Email field. I'll create a new issue and note the behavior you mentioned there.