Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better status message handling #429

Closed
saulipurhonen opened this issue Aug 17, 2021 · 0 comments
Closed

Better status message handling #429

saulipurhonen opened this issue Aug 17, 2021 · 0 comments
Assignees
@saulipurhonen
Labels
enhancement New feature or request

Comments

@saulipurhonen
Copy link
Contributor

Proposed solution

Most components use wizardStatusMessageHandler inside it's own render. This could be improved by using existing logic (wizardStatusMessageSlice) to have status message handler component only at project root. See src/components/NewDraftWizard/WizardHooks/WizardSaveDraftHook.js for example.

wizardStatusMessageHandler component is currently tied to wizard but can be refactored to work as a message handler for whole app since we need to have message handling at home routes too.

DoD (Definition of Done)

App snackbar alert messages are handled in app root only.

Testing

Integration & E2E tests.
@saulipurhonen saulipurhonen added the enhancement New feature or request label Aug 17, 2021
@saulipurhonen saulipurhonen self-assigned this Oct 11, 2021
This was referenced Oct 13, 2021
Merged
Merged
@hannyle hannyle closed this as completed Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saulipurhonen saulipurhonen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hannyle @saulipurhonen