-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/get organizations from ror api #416
Conversation
Get data from ROR API Autocomplete with options from ROR API
1831154
to
83e7f5d
Compare
83e7f5d
to
6723106
Compare
eea2855
to
57f5a32
Compare
57f5a32
to
eb07c57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe to the tooltip we can add that we are using ror.org
for a standardised list of institutions, that would be ideal, if possible
Sounds good to me. Would next sentence fit: |
yes sounds ok, if we can make ror.org hyperlink even better |
Hyperlink would need tooltip to stay open when user moves cursor out from icon. MUI has option for interactive tooltips, I'll look into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I think we can also mock the organisation data with cypress, I'm curious is there any other good reasons that we have it in unit test here?
that is a fair point |
Main reason for testing organisation data for autocomplete in unit test was to reduce weight on E2E CI pipeline. To be honest I'm getting a bit anxious when Cypress CI pipeline runs and fails multiple times with inconsistent reasons :/ However Cypress test for this feature could be handy since unit test doesn't test database interaction. |
yes, i am hopeful we can create an issue and spend some time on optimising the cypress test we can make them a tad better, but yes it is frustrating :( |
Description
Forms with
organisation
property in form schema are treated as autocomplete fields. Data is fetched from ROR API.Related issues
Closes #176
Type of change
Changes Made
autoCompleteIdentifiers
.Testing