Feature/doi form

[hannyle]

Description

• Added DOI form as optional for user to fill in before publishing folder
• DOI form comes with main features in creators, contributors and formats fields (Check this comment: Feature/doi form #455 (comment))
• Fixed bugs and made changes to FormAutocompleteField, FormArray, and FormTextField

Related issues

#407

Type of change

• Bug fixes (breaking change)
• New feature (non-breaking change which adds functionality)

Changes Made

• Optimised the search functionality for FormAutocompleteField
• Fixed bugs for FormAutocompleteField when user deletes some searching characters or enters some non-word ([, (, )) characters
• Fixed bugs for FormArray component so when user removes a certain field, data of the rest of the fields render correctly
• Add DOI form as a dialog at Summary step and it is optional to fill in the form
• Add some features in DOI form:
  • In Creators > Affliliations: user can search for name of the place of affiliation as an autocomplete field from ROR api.
  • The rest of the fields will be automatically filled with their correct values (in equivalent to the affiliation's name), with changes in FormTextField
  • The same functions go for Contributors > Affiliations
  • In Formats, the field(s) would be pre-filled with fileTypes that are submitted from Run and Analysis objects (if exists)
  • Add "nameType": "Personal" as a hidden static field for creators and contributors (back-end needs it)
• Data from DOI form is saved to currentFolder before publishing.
• Add e2e test for DOI form and FormArray
• Add description for FormArray

Testing

• Integration Tests

Mentions

• DOI form will be refactored as the last Wizard step before publishing folder in near future

[blankdots]

Seems something is off with some fields

---

O another note will try to add a schema so that we can control the fields values and information easier

[blankdots]

For the creators and contributors when filling out affiliations:

we should use same solution from: #416 it is used under DAC > Organization

---

List of formats can also be pre filled based on what users fill in into Run > Files > filetype field and Analysis > Files > filetype

---

For List of geolocations we will restrict the fields a list of countries and other fields will be refined

[blankdots]

or for the list of geolocations we can use https://nominatim.org/release-docs/develop/api/Search/ as an autocomplete to fill in the Spatial or named place.

Note: @hannyle if you think we need to split the changes I suggested into multiple issues then let us do that.

[hannyle]

Note: @hannyle if you think we need to split the changes I suggested into multiple issues then let us do that.

I can include the autocomplete fields of affiliations in this PR. For other features: List of formats and List of GeoLocations I think it's better to implement separately in other PRs.

[blankdots]

I can include the autocomplete fields of affiliations in this PR. For other features: List of formats and List of GeoLocations I think it's better to implement separately in other PRs.

Ok I will create issues about those

[saulipurhonen]

There seems to be problem within Affiliations field:
Clearing affiliation name doesn't clear other fields. It also seems that selecting a new place of affiliation doesn't change these fields.

2021-11-03.08-54-49.mp4

There also seems to be inconsistency when rendering ror.org affiliation data. In some cases other affiliation fields do not populate and some times they do.

2021-11-03.08-59-48.mp4

Also, clear button position seems to be a bit off but I think this could be fixed later

[hannyle]

There seems to be problem within Affiliations field: Clearing affiliation name doesn't clear other fields. It also seems that selecting a new place of affiliation doesn't change these fields.

2021-11-03.08-54-49.mp4

--> Good catch. I was planning to fix this but totally missed it at the end. I will fix it in this PR.

[saulipurhonen]

Saving of DOI form should be tested.

[hannyle]

• Data from DOI form is saved to currentFolder before publishing.

Should saving DOI info work? I get 400-error on "Save DOI info" button click.
Details: Request URL: http://localhost:3000/folders/9569d6b2d6084543b312b07fd4a8cca2 Request Method: PATCH Status Code: 400 Bad Request
Request Payload: [{"op":"add","path":"/doiInfo","value":{"creators":[{"givenName":"testName","nameType":{"nameType":"Personal"}}],"subjects":[{"subject":"FOS: Natural sciences"}]}}]

• Latest version of develop branch in backend
• Reinstalled NPM packages

I made a request with API client and found out that there seems to be some required field problems:

{ "type": "about:blank", "title": "Bad Request", "detail": "Provided input does not seem correct for field: 'doiInfo'", "instance": "/folders/9569d6b2d6084543b312b07fd4a8cca2" }

Right, it's due to my mistake in refactoring the hidden static field "nameType for DOI form.
Saving form should work now and I will update the test for it.

[hannyle]

There seems to be problem within Affiliations field: Clearing affiliation name doesn't clear other fields. It also seems that selecting a new place of affiliation doesn't change these fields.

2021-11-03.08-54-49.mp4
There also seems to be inconsistency when rendering ror.org affiliation data. In some cases other affiliation fields do not populate and some times they do.

2021-11-03.08-59-48.mp4
Also, clear button position seems to be a bit off but I think this could be fixed later

--> These issues should be fixed with the latest commits.

[hannyle]

Saving of DOI form should be tested.

--> Saving DOI form is included in cypress test now.

[lilachic]

When publishing a folder from draft list was there meant to be possibility add DOI information?

[hannyle]

When publishing a folder from draft list was there meant to be possibility add DOI information?

I think in this case, user can click Edit the draft folder and add the DOI Information. We don't have yet the option to add DOI info right from Draft Submission List, but that's a good idea to think about.

[saulipurhonen]

Apart from recent requests I did I'd say this looks great to me!

[blankdots]

tested and looks good.

Also added some missing information: #522

[blankdots]

will merge, as this got big enough. Anything else, to be addressed with follow up PRs