Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/dac main contact #333

Merged
merged 4 commits into from
Jun 16, 2021
Merged

Bugfix/dac main contact #333

merged 4 commits into from
Jun 16, 2021

Conversation

hannyle
Copy link
Contributor

@hannyle hannyle commented Jun 4, 2021

Description

In DAC form, the Main Contact checkbox is highlighted with * so that the user knows it's mandatory to have the Main Contact before submitting the form.

Related issues

Fix #331

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  • Add * to Main Contact label and make the checkbox as required when submitting DAC form
  • Fix to render the checkbox correctly as checked/unchecked when editing the DAC form

Testing

  • Tests do not apply

@hannyle hannyle self-assigned this Jun 4, 2021
@hannyle hannyle added the bug Something isn't working label Jun 4, 2021
@hannyle hannyle added this to the Beta - User Interaction milestone Jun 4, 2021
@hannyle hannyle linked an issue Jun 4, 2021 that may be closed by this pull request
@hannyle
Copy link
Contributor Author

hannyle commented Jun 10, 2021

Fixed so that name and email are always required for all contacts.

@hannyle hannyle merged commit 6da6aa7 into develop Jun 16, 2021
@hannyle hannyle deleted the bugfix/DAC-MainContact branch June 16, 2021 06:16
@blankdots blankdots mentioned this pull request Aug 11, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DAC Main Contact checkbox is not highlighted as required
2 participants