Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/predefined values and data types #180

Merged
merged 6 commits into from
Mar 9, 2021

Conversation

hannyle
Copy link
Contributor

@hannyle hannyle commented Mar 5, 2021

Description

Update the documentation for constants and data types

Related issues

#177

Type of change

  • Update documentation

Changes Made

Update documentation in architecture.md

Testing

  • Tests do not apply

@hannyle hannyle added the documentation Improvements or additions to documentation label Mar 5, 2021
@hannyle hannyle added this to the Beta - User Interaction milestone Mar 5, 2021
@hannyle hannyle self-assigned this Mar 5, 2021
@hannyle hannyle linked an issue Mar 5, 2021 that may be closed by this pull request
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion for improvement: I would mention that https://github.com/CSCfi/metadata-submitter-frontend/blob/docs/predefined-values-and-dataTypes/src/constants/wizardObject.js#L12 ObjectsArray needs to be kept in sync with the schemas that are in back-end, otherwise there might appear some issues.

Copy link
Contributor

@lilachic lilachic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@hannyle
Copy link
Contributor Author

hannyle commented Mar 8, 2021

A suggestion for improvement: I would mention that https://github.com/CSCfi/metadata-submitter-frontend/blob/docs/predefined-values-and-dataTypes/src/constants/wizardObject.js#L12 ObjectsArray needs to be kept in sync with the schemas that are in back-end, otherwise there might appear some issues.

I integrated the schemas to be objectsArray in front-end.

@blankdots blankdots merged commit cae1907 into develop Mar 9, 2021
@blankdots blankdots deleted the docs/predefined-values-and-dataTypes branch March 9, 2021 06:14
This was referenced Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document constant files for predefined values
4 participants