Feature/design improvements #184

saulipurhonen · 2021-03-09T13:15:26Z

Description

Mostly minor improvements for more consistent design.

Related issues

Closes #175

Type of change

New feature (non-breaking change which adds functionality)

Changes Made

Create New Folder > Create Submission
Main grid spacing
Consistent card and grid object headers
Subtitle colors
Checkbox positions
Nested form section width control
Highlight required fields
Global theme enhancements
Saved and draft object badges
List draft and published folders via router
Navigation link targets for "Open submissions" and "Submissions"
Removed icons before object type labels in object index
Display submitted object count with icon and tooltip
Display draft count next to submission label in object index
Wrapped RTL tests with theme provider
Submission action button background color

Testing

Tests do not apply

bump to 0.7.0

Simplify for trying out setup with docker-compose by using the network name docker will pick for backend by default if the repository has been cloned without specifying the directory to clone to.

Use naming consistent with default behaviour

bump to 0.8.0

WIP

src/components/NewDraftWizard/WizardComponents/WizardObjectIndex.js

…able components

…ex.js Co-authored-by: Hang Le <[email protected]>

saulipurhonen · 2021-03-11T10:47:46Z

Improved with following changes:

Separated folder listing and folder detail logic to reusable components
Routing with previously described components
Display folder details via router eg. /home/drafts/<accessionId>

blankdots

looks ok, no additional issues i can spot

lilachic · 2021-03-11T15:53:22Z

Related maybe to src/components/NewDraftWizard/WizardForms/WizardJSONSchemaParser.js , I get error "TypeError: Cannot read property 'id' of undefined" , when clicking xx Links Add new item , where xx is Study, Run ... ?

blankdots · 2021-03-11T16:33:05Z

@lilachic yeah i get that as well, i assume #182 changes were just merged to develop and this branch does not contain those changes

…i/metadata-submitter-frontend into feature/design-improvements

saulipurhonen · 2021-03-12T07:05:09Z

@lilachic yeah i get that as well, i assume #182 changes were just merged to develop and this branch does not contain those changes

This is correct. @blankdots should I rebase develop to this branch or is it good to go as it is?

blankdots · 2021-03-12T07:17:48Z

either is fine, for me. I already approved.

hannyle · 2021-03-12T09:03:10Z

src/components/Home/SelectedFolderDetails.js

+
+  // Delete object from current folder
+  const handleDeleteObject = async (objectId: string, objectType: string, objectStatus: string) => {
+    console.log(objectStatus)


console.log is still here

src/components/Home/SelectedFolderDetails.js

hannyle · 2021-03-12T09:05:47Z

Looks really good to me. I like that now every component in Home has separate routes.

hannyle · 2021-03-12T09:11:06Z

Only 1 small thing:

When I am at, for e.g, /home/published route, the only way to go back Home is by clicking Home icon, I guess.
My 2 cent is maybe we can have the same link <-- to go back Home like we have with <-- Your published submissions.
Or we can remove <-- Your published submissions and use browser's Back button is enough.
I just want to make it consistent when navigating.
This can be done in another PR also.

Co-authored-by: Hang Le <[email protected]>

saulipurhonen · 2021-03-12T09:47:48Z

Only 1 small thing:

When I am at, for e.g, /home/published route, the only way to go back Home is by clicking Home icon, I guess.
My 2 cent is maybe we can have the same link <-- to go back Home like we have with <-- Your published submissions.
Or we can remove <-- Your published submissions and use browser's Back button is enough.
I just want to make it consistent when navigating.
This can be done in another PR also.

This sounds like a good feature. Should be minor change so I'll add into this PR.

…i/metadata-submitter-frontend into feature/design-improvements

saulipurhonen · 2021-03-12T10:33:44Z

Only 1 small thing:
When I am at, for e.g, /home/published route, the only way to go back Home is by clicking Home icon, I guess.
My 2 cent is maybe we can have the same link <-- to go back Home like we have with <-- Your published submissions.
Or we can remove <-- Your published submissions and use browser's Back button is enough.
I just want to make it consistent when navigating.
This can be done in another PR also.

This sounds like a good feature. Should be minor change so I'll add into this PR.

I implemented this logic with breadcrumbs.

hannyle

Looks nice!

blankdots and others added 28 commits January 19, 2021 17:10

Merge pull request #134 from CSCfi/develop

34127ec

bump to 0.7.0

Use naming consistent with default behaviour

888490b

Simplify for trying out setup with docker-compose by using the network name docker will pick for backend by default if the repository has been cloned without specifying the directory to clone to.

Merge pull request #137 from pontus/feature/consistent_network_naming

6eb7a5d

Use naming consistent with default behaviour

Merge pull request #165 from CSCfi/develop

4cd13d4

bump to 0.8.0

Fix for Home unit test error

4a82f22

Add constant file for submissionTypes

5430554

Fix for related unit tests

3b0a58f

Add constant file for objectTypes

1da11c3

Update files related to SubmissionStatus

f974431

Update files related to ObjectSubmissionTypes and ObjectTypes

ddf8473

Update files related to ObjectStatus

5ad82e5

Add constant file for WizardStatus and update related files

8828763

update packages to latest

9ee17c0

add husky pre-commit

254e0eb

small fixes to e2e tests

f0d7403

don't use strict mode in avj

5e2584e

update packages

a55f114

update to latest packages

331f3e7

downgrade flow-bin

f56ae26

correct package lock

5eb5c60

update packages again

200b12e

Update flow-bin to latest and fix all the files' warnings

48c3d16

Create one folder for common types and update related files

21a7478

WIP

Add missing dataTypes in some files

963926e

Design improvements

67b369c

Submission actions and object index styles

9308045

Resolved conflict

1c311ff

Resolved merge conflicts

f8e771e

saulipurhonen added the enhancement New feature or request label Mar 9, 2021

saulipurhonen added this to the Beta - User Interaction milestone Mar 9, 2021

lilachic reviewed Mar 10, 2021

View reviewed changes

src/components/NewDraftWizard/WizardComponents/WizardObjectIndex.js Outdated Show resolved Hide resolved

saulipurhonen and others added 3 commits March 11, 2021 10:54

Separate submission folder listing and detail display logic into reus…

20943c8

…able components

Update src/components/NewDraftWizard/WizardComponents/WizardObjectInd…

29a10eb

…ex.js Co-authored-by: Hang Le <[email protected]>

Resolved conflict

1342d3b

saulipurhonen force-pushed the feature/design-improvements branch from cfef451 to 1342d3b Compare March 11, 2021 09:55

saulipurhonen added the design eye candy and user interaction improvement label Mar 11, 2021

saulipurhonen linked an issue Mar 11, 2021 that may be closed by this pull request

Tackle Design issues #175

Closed

blankdots approved these changes Mar 11, 2021

View reviewed changes

Merge branch 'feature/design-improvements' of https://github.com/CSCf…

becfc92

…i/metadata-submitter-frontend into feature/design-improvements

lilachic approved these changes Mar 12, 2021

View reviewed changes

hannyle reviewed Mar 12, 2021

View reviewed changes

src/components/Home/SelectedFolderDetails.js Outdated Show resolved Hide resolved

Update src/components/Home/SelectedFolderDetails.js

9c8889e

Co-authored-by: Hang Le <[email protected]>

saulipurhonen added 2 commits March 12, 2021 11:56

Merge branch 'feature/design-improvements' of https://github.com/CSCf…

13cbacd

…i/metadata-submitter-frontend into feature/design-improvements

Breadcrumbs for folders

b72b279

hannyle approved these changes Mar 12, 2021

View reviewed changes

blankdots merged commit fab3b7d into develop Mar 12, 2021

blankdots deleted the feature/design-improvements branch March 12, 2021 11:31

blankdots mentioned this pull request Mar 15, 2021

release 0.9.0 #186

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/design improvements #184

Feature/design improvements #184

saulipurhonen commented Mar 9, 2021

saulipurhonen commented Mar 11, 2021

blankdots left a comment

lilachic commented Mar 11, 2021

blankdots commented Mar 11, 2021

saulipurhonen commented Mar 12, 2021

blankdots commented Mar 12, 2021

hannyle Mar 12, 2021

hannyle commented Mar 12, 2021

hannyle commented Mar 12, 2021 •

edited

Loading

saulipurhonen commented Mar 12, 2021

saulipurhonen commented Mar 12, 2021

hannyle left a comment

Feature/design improvements #184

Feature/design improvements #184

Conversation

saulipurhonen commented Mar 9, 2021

Description

Related issues

Type of change

Changes Made

Testing

saulipurhonen commented Mar 11, 2021

blankdots left a comment

Choose a reason for hiding this comment

lilachic commented Mar 11, 2021

blankdots commented Mar 11, 2021

saulipurhonen commented Mar 12, 2021

blankdots commented Mar 12, 2021

hannyle Mar 12, 2021

Choose a reason for hiding this comment

hannyle commented Mar 12, 2021

hannyle commented Mar 12, 2021 • edited Loading

saulipurhonen commented Mar 12, 2021

saulipurhonen commented Mar 12, 2021

hannyle left a comment

Choose a reason for hiding this comment

hannyle commented Mar 12, 2021 •

edited

Loading