Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance FindCommand #86

Merged
merged 16 commits into from
Mar 18, 2019
Merged

Conversation

marcus-pzj
Copy link
Member

No description provided.

@marcus-pzj marcus-pzj added the priority.High Must do label Mar 18, 2019
@marcus-pzj marcus-pzj added this to the v1.2 milestone Mar 18, 2019
@marcus-pzj marcus-pzj self-assigned this Mar 18, 2019
@marcus-pzj
Copy link
Member Author

Fulfils #60

@marcus-pzj marcus-pzj requested a review from seanieyap March 18, 2019 08:55
Copy link

@dingheng4448 dingheng4448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Remember to write the JUnit tests too.

@dingheng4448 dingheng4448 merged commit ad0c59e into CS2113-AY1819S2-T08-3:master Mar 18, 2019
marcus-pzj added a commit to marcus-pzj/main that referenced this pull request Mar 18, 2019
* added Encryptor class to encrypt and decrypt storage data

* set encryption to false

* added junit class

* checkstyle edits

* removed junit test

* checkstyle edits

* more checkstyle edits

* Update documentation for encryption

* export calendar as .ics file

* checkstyle edits

* added some documentation

* Update developer guide for export

* Add User Stories (CS2113-AY1819S2-T08-3#83)

* Resolve checkstyle errors (CS2113-AY1819S2-T08-3#85)

* Enhance FindCommand (CS2113-AY1819S2-T08-3#86)

* Add view command for monthly calendar view (CS2113-AY1819S2-T08-3#87)

* Planner: Initialize weekType for each Day

* Planner: Fix Codacy issue

* Planner: Update code for initialisation of semester

* Planner: Fix Codacy and checkstyle issues

* Planner: Fix build error

* Planner: Dynamic generation of semester from date

* PlannerTest: Add JUnit test for generateSemester

* Update documentation for view command

* Add view command for monthly calendar view

* Fix Codacy issue

* Add test cases for add function, Utils and other code enhancements (CS2113-AY1819S2-T08-3#88)

* v1.1

* fix some errors and typos

* Refactor entire project, remove all traces of Addressbook

* Update developer guide for ExportCommandP (CS2113-AY1819S2-T08-3#80)

* Update documentation for view command (CS2113-AY1819S2-T08-3#81)

* Remove remaining Addressbook classes

* Refactor some classes

* fix missing files issue

* Add test cases for add function, Utils and other code enhancements

* fix codacy issues

* fix codacy issues
seanieyap pushed a commit that referenced this pull request Mar 18, 2019
* Add User Stories

* Merge (#12)

* added Encryptor class to encrypt and decrypt storage data

* set encryption to false

* added junit class

* checkstyle edits

* removed junit test

* checkstyle edits

* more checkstyle edits

* Update documentation for encryption

* export calendar as .ics file

* checkstyle edits

* added some documentation

* Update developer guide for export

* Add User Stories (#83)

* Resolve checkstyle errors (#85)

* Enhance FindCommand (#86)

* Add view command for monthly calendar view (#87)

* Planner: Initialize weekType for each Day

* Planner: Fix Codacy issue

* Planner: Update code for initialisation of semester

* Planner: Fix Codacy and checkstyle issues

* Planner: Fix build error

* Planner: Dynamic generation of semester from date

* PlannerTest: Add JUnit test for generateSemester

* Update documentation for view command

* Add view command for monthly calendar view

* Fix Codacy issue

* Add test cases for add function, Utils and other code enhancements (#88)

* v1.1

* fix some errors and typos

* Refactor entire project, remove all traces of Addressbook

* Update developer guide for ExportCommandP (#80)

* Update documentation for view command (#81)

* Remove remaining Addressbook classes

* Refactor some classes

* fix missing files issue

* Add test cases for add function, Utils and other code enhancements

* fix codacy issues

* fix codacy issues

* Update documentation: User Guide & Developer Guide

* Edit Developer Guide to remove AB
marcus-pzj added a commit to marcus-pzj/main that referenced this pull request Mar 18, 2019
* added Encryptor class to encrypt and decrypt storage data

* set encryption to false

* added junit class

* checkstyle edits

* removed junit test

* checkstyle edits

* more checkstyle edits

* Update documentation for encryption

* export calendar as .ics file

* checkstyle edits

* added some documentation

* Update developer guide for export

* Add User Stories (CS2113-AY1819S2-T08-3#83)

* Resolve checkstyle errors (CS2113-AY1819S2-T08-3#85)

* Enhance FindCommand (CS2113-AY1819S2-T08-3#86)

* Add view command for monthly calendar view (CS2113-AY1819S2-T08-3#87)

* Planner: Initialize weekType for each Day

* Planner: Fix Codacy issue

* Planner: Update code for initialisation of semester

* Planner: Fix Codacy and checkstyle issues

* Planner: Fix build error

* Planner: Dynamic generation of semester from date

* PlannerTest: Add JUnit test for generateSemester

* Update documentation for view command

* Add view command for monthly calendar view

* Fix Codacy issue

* Add test cases for add function, Utils and other code enhancements (CS2113-AY1819S2-T08-3#88)

* v1.1

* fix some errors and typos

* Refactor entire project, remove all traces of Addressbook

* Update developer guide for ExportCommandP (CS2113-AY1819S2-T08-3#80)

* Update documentation for view command (CS2113-AY1819S2-T08-3#81)

* Remove remaining Addressbook classes

* Refactor some classes

* fix missing files issue

* Add test cases for add function, Utils and other code enhancements

* fix codacy issues

* fix codacy issues

* Update use cases in developer guide (CS2113-AY1819S2-T08-3#90)

* Resolve checkstyle errors

* Update use cases in developer guide

* Update Documentation (CS2113-AY1819S2-T08-3#89)

* Add User Stories

* Merge (#12)

* added Encryptor class to encrypt and decrypt storage data

* set encryption to false

* added junit class

* checkstyle edits

* removed junit test

* checkstyle edits

* more checkstyle edits

* Update documentation for encryption

* export calendar as .ics file

* checkstyle edits

* added some documentation

* Update developer guide for export

* Add User Stories (CS2113-AY1819S2-T08-3#83)

* Resolve checkstyle errors (CS2113-AY1819S2-T08-3#85)

* Enhance FindCommand (CS2113-AY1819S2-T08-3#86)

* Add view command for monthly calendar view (CS2113-AY1819S2-T08-3#87)

* Planner: Initialize weekType for each Day

* Planner: Fix Codacy issue

* Planner: Update code for initialisation of semester

* Planner: Fix Codacy and checkstyle issues

* Planner: Fix build error

* Planner: Dynamic generation of semester from date

* PlannerTest: Add JUnit test for generateSemester

* Update documentation for view command

* Add view command for monthly calendar view

* Fix Codacy issue

* Add test cases for add function, Utils and other code enhancements (CS2113-AY1819S2-T08-3#88)

* v1.1

* fix some errors and typos

* Refactor entire project, remove all traces of Addressbook

* Update developer guide for ExportCommandP (CS2113-AY1819S2-T08-3#80)

* Update documentation for view command (CS2113-AY1819S2-T08-3#81)

* Remove remaining Addressbook classes

* Refactor some classes

* fix missing files issue

* Add test cases for add function, Utils and other code enhancements

* fix codacy issues

* fix codacy issues

* Update documentation: User Guide & Developer Guide

* Edit Developer Guide to remove AB

* v1.2 (CS2113-AY1819S2-T08-3#94)
@marcus-pzj marcus-pzj deleted the 1.2 branch March 19, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants