forked from nusCS2113-AY1819S2/addressbook-level3
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add User Stories; Fulfil 30 user stories #83
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge Refactor
Add Add functionality
Add delete command, JUnit test for Planner
Refactor class names, remove remaining traces of addressbook (CS2113-AY1819S2-T08-3#82)
marcus-pzj
added
type.Task
Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
priority.Medium
Nice to have
labels
Mar 17, 2019
seanieyap
reviewed
Mar 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues here. Good addition of user stories
marcus-pzj
added a commit
to marcus-pzj/main
that referenced
this pull request
Mar 18, 2019
* added Encryptor class to encrypt and decrypt storage data * set encryption to false * added junit class * checkstyle edits * removed junit test * checkstyle edits * more checkstyle edits * Update documentation for encryption * export calendar as .ics file * checkstyle edits * added some documentation * Update developer guide for export * Add User Stories (CS2113-AY1819S2-T08-3#83) * Resolve checkstyle errors (CS2113-AY1819S2-T08-3#85) * Enhance FindCommand (CS2113-AY1819S2-T08-3#86) * Add view command for monthly calendar view (CS2113-AY1819S2-T08-3#87) * Planner: Initialize weekType for each Day * Planner: Fix Codacy issue * Planner: Update code for initialisation of semester * Planner: Fix Codacy and checkstyle issues * Planner: Fix build error * Planner: Dynamic generation of semester from date * PlannerTest: Add JUnit test for generateSemester * Update documentation for view command * Add view command for monthly calendar view * Fix Codacy issue * Add test cases for add function, Utils and other code enhancements (CS2113-AY1819S2-T08-3#88) * v1.1 * fix some errors and typos * Refactor entire project, remove all traces of Addressbook * Update developer guide for ExportCommandP (CS2113-AY1819S2-T08-3#80) * Update documentation for view command (CS2113-AY1819S2-T08-3#81) * Remove remaining Addressbook classes * Refactor some classes * fix missing files issue * Add test cases for add function, Utils and other code enhancements * fix codacy issues * fix codacy issues
seanieyap
pushed a commit
that referenced
this pull request
Mar 18, 2019
* Add User Stories * Merge (#12) * added Encryptor class to encrypt and decrypt storage data * set encryption to false * added junit class * checkstyle edits * removed junit test * checkstyle edits * more checkstyle edits * Update documentation for encryption * export calendar as .ics file * checkstyle edits * added some documentation * Update developer guide for export * Add User Stories (#83) * Resolve checkstyle errors (#85) * Enhance FindCommand (#86) * Add view command for monthly calendar view (#87) * Planner: Initialize weekType for each Day * Planner: Fix Codacy issue * Planner: Update code for initialisation of semester * Planner: Fix Codacy and checkstyle issues * Planner: Fix build error * Planner: Dynamic generation of semester from date * PlannerTest: Add JUnit test for generateSemester * Update documentation for view command * Add view command for monthly calendar view * Fix Codacy issue * Add test cases for add function, Utils and other code enhancements (#88) * v1.1 * fix some errors and typos * Refactor entire project, remove all traces of Addressbook * Update developer guide for ExportCommandP (#80) * Update documentation for view command (#81) * Remove remaining Addressbook classes * Refactor some classes * fix missing files issue * Add test cases for add function, Utils and other code enhancements * fix codacy issues * fix codacy issues * Update documentation: User Guide & Developer Guide * Edit Developer Guide to remove AB
marcus-pzj
added a commit
to marcus-pzj/main
that referenced
this pull request
Mar 18, 2019
* added Encryptor class to encrypt and decrypt storage data * set encryption to false * added junit class * checkstyle edits * removed junit test * checkstyle edits * more checkstyle edits * Update documentation for encryption * export calendar as .ics file * checkstyle edits * added some documentation * Update developer guide for export * Add User Stories (CS2113-AY1819S2-T08-3#83) * Resolve checkstyle errors (CS2113-AY1819S2-T08-3#85) * Enhance FindCommand (CS2113-AY1819S2-T08-3#86) * Add view command for monthly calendar view (CS2113-AY1819S2-T08-3#87) * Planner: Initialize weekType for each Day * Planner: Fix Codacy issue * Planner: Update code for initialisation of semester * Planner: Fix Codacy and checkstyle issues * Planner: Fix build error * Planner: Dynamic generation of semester from date * PlannerTest: Add JUnit test for generateSemester * Update documentation for view command * Add view command for monthly calendar view * Fix Codacy issue * Add test cases for add function, Utils and other code enhancements (CS2113-AY1819S2-T08-3#88) * v1.1 * fix some errors and typos * Refactor entire project, remove all traces of Addressbook * Update developer guide for ExportCommandP (CS2113-AY1819S2-T08-3#80) * Update documentation for view command (CS2113-AY1819S2-T08-3#81) * Remove remaining Addressbook classes * Refactor some classes * fix missing files issue * Add test cases for add function, Utils and other code enhancements * fix codacy issues * fix codacy issues * Update use cases in developer guide (CS2113-AY1819S2-T08-3#90) * Resolve checkstyle errors * Update use cases in developer guide * Update Documentation (CS2113-AY1819S2-T08-3#89) * Add User Stories * Merge (#12) * added Encryptor class to encrypt and decrypt storage data * set encryption to false * added junit class * checkstyle edits * removed junit test * checkstyle edits * more checkstyle edits * Update documentation for encryption * export calendar as .ics file * checkstyle edits * added some documentation * Update developer guide for export * Add User Stories (CS2113-AY1819S2-T08-3#83) * Resolve checkstyle errors (CS2113-AY1819S2-T08-3#85) * Enhance FindCommand (CS2113-AY1819S2-T08-3#86) * Add view command for monthly calendar view (CS2113-AY1819S2-T08-3#87) * Planner: Initialize weekType for each Day * Planner: Fix Codacy issue * Planner: Update code for initialisation of semester * Planner: Fix Codacy and checkstyle issues * Planner: Fix build error * Planner: Dynamic generation of semester from date * PlannerTest: Add JUnit test for generateSemester * Update documentation for view command * Add view command for monthly calendar view * Fix Codacy issue * Add test cases for add function, Utils and other code enhancements (CS2113-AY1819S2-T08-3#88) * v1.1 * fix some errors and typos * Refactor entire project, remove all traces of Addressbook * Update developer guide for ExportCommandP (CS2113-AY1819S2-T08-3#80) * Update documentation for view command (CS2113-AY1819S2-T08-3#81) * Remove remaining Addressbook classes * Refactor some classes * fix missing files issue * Add test cases for add function, Utils and other code enhancements * fix codacy issues * fix codacy issues * Update documentation: User Guide & Developer Guide * Edit Developer Guide to remove AB * v1.2 (CS2113-AY1819S2-T08-3#94)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority.Medium
Nice to have
type.Task
Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fulfils #40