Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: angle type no longer parametric. #577

Merged
merged 2 commits into from
Sep 4, 2024
Merged

feat!: angle type no longer parametric. #577

merged 2 commits into from
Sep 4, 2024

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Sep 3, 2024

Closes #576

BREAKING CHANGE: Angle type not parametric on log denominator. Aconvert op removed, along with type paramateric helper functions

Closes #576

BREAKING CHANGE: Angle type not parametric on log denominator. Aconvert op removed, along with type paramateric helper functions
@ss2165 ss2165 requested a review from a team as a code owner September 3, 2024 16:54
@ss2165 ss2165 requested a review from lmondada September 3, 2024 16:54
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.79%. Comparing base (42cc82f) to head (1d26a3e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tket2/src/extension/angle.rs 97.72% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
- Coverage   82.91%   82.79%   -0.13%     
==========================================
  Files          45       45              
  Lines        6206     6113      -93     
  Branches     6206     6113      -93     
==========================================
- Hits         5146     5061      -85     
+ Misses        776      770       -6     
+ Partials      284      282       -2     
Flag Coverage Δ
rust 82.79% <97.72%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ss2165 ss2165 removed the request for review from lmondada September 3, 2024 17:51
@ss2165 ss2165 assigned cqc-alec and unassigned cqc-alec Sep 3, 2024
@ss2165 ss2165 requested a review from cqc-alec September 3, 2024 17:51
@ss2165 ss2165 mentioned this pull request Sep 3, 2024
tket2/src/extension/angle.rs Outdated Show resolved Hide resolved
tket2/src/extension/angle.rs Outdated Show resolved Hide resolved
tket2/src/extension/angle.rs Outdated Show resolved Hide resolved
Co-authored-by: Alec Edgington <[email protected]>
@ss2165 ss2165 requested a review from cqc-alec September 4, 2024 08:22
@ss2165 ss2165 added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 62351fb Sep 4, 2024
15 checks passed
@ss2165 ss2165 deleted the ss/angle-nonparam branch September 4, 2024 08:44
@hugrbot hugrbot mentioned this pull request Sep 3, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2024
## 🤖 New release
* `tket2`: 0.1.1 -> 0.2.0
* `tket2-hseries`: 0.1.1 -> 0.2.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `tket2`
<blockquote>

##
[0.2.0](tket2-v0.1.1...tket2-v0.2.0)
- 2024-09-04

### Bug Fixes
- [**breaking**] quantum extension name wrong way round
([#582](#582))

### New Features
- Extend Command::optype lifetime
([#562](#562))
- [**breaking**] Update rust hugr dependency to `0.12.0`, and python
hugr to `0.8.0` ([#568](#568))
- [**breaking**] remove Tk2Op::AngleAdd
([#567](#567))
- [**breaking**] angle type no longer parametric.
([#577](#577))
- [**breaking**] HSeries ops
([#573](#573))
- [**breaking**] replace f64 with angle type for tk2 ops
([#578](#578))
- more angle ops (construct, deconstruct, radians, equality)
([#581](#581))
</blockquote>

## `tket2-hseries`
<blockquote>

##
[0.2.0](tket2-hseries-v0.1.1...tket2-hseries-v0.2.0)
- 2024-09-04

### New Features
- [**breaking**] Update rust hugr dependency to `0.12.0`, and python
hugr to `0.8.0` ([#568](#568))
- [**breaking**] HSeries ops
([#573](#573))
- [**breaking**] replace f64 with angle type for tk2 ops
([#578](#578))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angle type should not be parametric
2 participants