-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove Tk2Op::AngleAdd #567
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
==========================================
- Coverage 83.01% 82.91% -0.10%
==========================================
Files 45 45
Lines 6213 6206 -7
Branches 6213 6206 -7
==========================================
- Hits 5158 5146 -12
- Misses 773 776 +3
- Partials 282 284 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I agree we should wait for hugr bump. Happy to approve if you decide you want to merge now
edd3441
to
792b95d
Compare
Closes #566 BREAKING CHANGE: `Tk2Op::AngleAdd` removed, use `fadd` from the hugr float ops standard extension
Co-authored-by: Douglas Wilson <[email protected]>
ce088ad
to
7bfafc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! One orphaned comment to delete.
Co-authored-by: Douglas Wilson <[email protected]>
🤖 I have created a release *beep* *boop* --- ## [0.3.0](tket2-py-v0.2.1...tket2-py-v0.3.0) (2024-09-04) ### ⚠ BREAKING CHANGES * quantum extension renamed from "quantum.tket2" to "tket2.quantum" * Parametric Tk2Ops take angle type rather than float. * Rename lazy extension to "hseries" and add hseries ops. * `Tk2Op::AngleAdd` removed, use `fadd` from the hugr float ops standard extension * Updated to latest hugr version (`hugr-rs 0.12` / `hugr-py 0.8`). ECCs need to be recompiled. ### Features * HSeries ops ([#573](#573)) ([e6acc88](e6acc88)) * remove Tk2Op::AngleAdd ([#567](#567)) ([42cc82f](42cc82f)) * replace f64 with angle type for tk2 ops ([#578](#578)) ([d14631f](d14631f)) * Update rust hugr dependency to `0.12.0`, and python hugr to `0.8.0` ([#568](#568)) ([258a7c5](258a7c5)) ### Bug Fixes * quantum extension name wrong way round ([#582](#582)) ([06a6838](06a6838)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
## 🤖 New release * `tket2`: 0.1.1 -> 0.2.0 * `tket2-hseries`: 0.1.1 -> 0.2.0 <details><summary><i><b>Changelog</b></i></summary><p> ## `tket2` <blockquote> ## [0.2.0](tket2-v0.1.1...tket2-v0.2.0) - 2024-09-04 ### Bug Fixes - [**breaking**] quantum extension name wrong way round ([#582](#582)) ### New Features - Extend Command::optype lifetime ([#562](#562)) - [**breaking**] Update rust hugr dependency to `0.12.0`, and python hugr to `0.8.0` ([#568](#568)) - [**breaking**] remove Tk2Op::AngleAdd ([#567](#567)) - [**breaking**] angle type no longer parametric. ([#577](#577)) - [**breaking**] HSeries ops ([#573](#573)) - [**breaking**] replace f64 with angle type for tk2 ops ([#578](#578)) - more angle ops (construct, deconstruct, radians, equality) ([#581](#581)) </blockquote> ## `tket2-hseries` <blockquote> ## [0.2.0](tket2-hseries-v0.1.1...tket2-hseries-v0.2.0) - 2024-09-04 ### New Features - [**breaking**] Update rust hugr dependency to `0.12.0`, and python hugr to `0.8.0` ([#568](#568)) - [**breaking**] HSeries ops ([#573](#573)) - [**breaking**] replace f64 with angle type for tk2 ops ([#578](#578)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Closes #566
BREAKING CHANGE:
Tk2Op::AngleAdd
removed, usefadd
from the hugr float ops standard extension