fix!: Update ToffoliBox permutation type #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannah-mcdougall
changed the title
|
Ouch. Seems like the current Would you mind renaming that struct to /// A classic basis state permutation.
///
/// Used when defining Toffoli boxes.
#[derive(Deserialize, Serialize, Clone, Debug, PartialEq, Eq, Hash)]
#[serde(transparent)]
pub struct Permutation(Vec<(Vec<bool>, Vec<bool>)>);to use in the Toffoli box? |
aborgna-q
approved these changes
Aug 6, 2024
Co-authored-by: Agustín Borgna <[email protected]>
Merged
aborgna-q
changed the title
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
## 🤖 New release * `tket-json-rs`: 0.5.1 -> 0.6.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## 0.6.0 (2024-08-06) ### Bug Fixes - Update ToffoliBox permutation type ([#64](#64)) ### Features - [**breaking**] Add support for WASM operations ([#61](#61)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: Agustín Borgna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated ToffoliBox permutation type to match tket schema and nexus dataclasses. This inconsistency caused failures when getting circuits that include a ToffoliBox from the database.
BREAKING CHANGE: Renamed
PermutationtoImplicitPermutation