Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Add support for WASM operations #61

Merged
merged 2 commits into from
Aug 6, 2024
Merged

feat!: Add support for WASM operations #61

merged 2 commits into from
Aug 6, 2024

Conversation

johnchildren
Copy link
Contributor

@johnchildren johnchildren commented Jul 30, 2024 •
edited by aborgna-q
Loading

BREAKING CHANGE: Added a number_of_ws field to SerialCircuit

@aborgna-q
Copy link
Collaborator

Where is this part of the schema defined?
It's not in https://github.com/CQCL/tket/blob/develop/schemas/circuit_v1.json

johnchildren
johnchildren commented Jul 30, 2024
View reviewed changes
src/circuit_json.rs Outdated Show resolved Hide resolved
@johnchildren
Copy link
Contributor Author

Where is this part of the schema defined? It's not in https://github.com/CQCL/tket/blob/develop/schemas/circuit_v1.json

A very good question... I had to dig into the C++ to find out how it worked: https://github.com/CQCL/tket/blob/da1f491059b608701701da6202abb96c67ac6031/tket/src/Ops/ClassicalOps.cpp#L143

@aborgna-q
Copy link
Collaborator

-.-

I'll make an issue

@johnchildren
Copy link
Contributor Author

Honestly if they aren't too set on the schema yet there are some improvements I'd perhaps like to make such as renaming wasm_file_uid to uid

@aborgna-q aborgna-q mentioned this pull request Jul 30, 2024
Open
aborgna-q
aborgna-q approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We can wait for CQCL/tket#1505 to be resolved if you prefer so.

@johnchildren
Copy link
Contributor Author

LGTM

We can wait for CQCL/tket#1505 to be resolved if you prefer so.

Yeah I guess I'd just want to hear what the outcome of that is first, happy to wait a little while as I don't need this till later in the week I expect.

@aborgna-q aborgna-q changed the title feat: Add support for WASM operations feat!: Add support for WASM operations Aug 6, 2024
@aborgna-q
Copy link
Collaborator

Merging this as-is. We can update it once the tket issue is resolved.

@aborgna-q aborgna-q added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit 6b531f9 Aug 6, 2024
8 of 9 checks passed
@aborgna-q aborgna-q deleted the feat/wasm-support branch August 6, 2024 13:11
@hugrbot hugrbot mentioned this pull request Aug 6, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 6, 2024
@hugrbot @aborgna-q
chore: release v0.6.0 (#63)
213c93d 
## 🤖 New release
* `tket-json-rs`: 0.5.1 -> 0.6.0

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## 0.6.0 (2024-08-06)

### Bug Fixes

- Update ToffoliBox permutation type
([#64](#64))

### Features

- [**breaking**] Add support for WASM operations
([#61](#61))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: Agustín Borgna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aborgna-q aborgna-q aborgna-q approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnchildren @aborgna-q