fix: Do not require matching extension_reqs when creating a replacement #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborgna-q
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
==========================================
+ Coverage 87.09% 87.12% +0.03%
==========================================
Files 97 97
Lines 19285 19288 +3
Branches 18420 18423 +3
==========================================
+ Hits 16796 16805 +9
+ Misses 1636 1630 -6
Partials 853 853
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…nt from a sibling graph
aborgna-q
force-pushed
the
ab/less-strict-replacement
branch
from
4e1bbba
to
28ef30d
Compare
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
## 🤖 New release * `hugr`: 0.5.0 -> 0.5.1 * `hugr-core`: 0.1.0 -> 0.2.0 * `hugr-passes`: 0.1.0 -> 0.2.0 * `hugr-cli`: 0.1.0 -> 0.1.1 <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## 0.5.1 (2024-06-07) ### Refactor - Move binary to hugr-cli ([#1134](#1134)) </blockquote> ## `hugr-core` <blockquote> ## 0.2.0 (2024-06-07) ### Bug Fixes - [**breaking**] Validate that control-flow outputs have exactly one successor ([#1144](#1144)) - Do not require matching extension_reqs when creating a replacement ([#1177](#1177)) ### Features - Add `ConstExternalSymbol` to prelude ([#1123](#1123)) - `HugrView::extract_hugr` to extract regions into owned hugrs. ([#1173](#1173)) ### Testing - Serialisation round trip testing for `OpDef` ([#999](#999)) </blockquote> ## `hugr-passes` <blockquote> ## 0.2.0 (2024-06-07) ### Features - Add `ValidationLevel` tooling and apply to `constant_fold_pass` ([#1035](#1035)) </blockquote> ## `hugr-cli` <blockquote> ## 0.1.1 (2024-06-07) ### Features - Reexport `clap::Parser` and `clap_verbosity_flag::Level` from hugr_cli ([#1146](#1146)) ### Refactor - Move binary to hugr-cli ([#1134](#1134)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
github-merge-queue bot
pushed a commit
to CQCL/tket2
that referenced
this pull request
Jun 17, 2024
…ors (#390) - Stores the circuit name in the `FuncDefn` operations instead of a "name" metadata key. In the future we will decode tket1 circuits into funtion definitions instead of Dfg blocks, but that currently causes errors due to CQCL/hugr#1175. - `Circuit::circuit_signature` returns a `FunctionType` instead of a `PolyFuncType`, since we (currently) don't allow parametric signatures. - Improves the errors when constructing and manipulating circuits. This work is in the path to solving #385 and #389, but we will require some fixes in hugr (CQCL/hugr#1177) before fixing the support for non-Dfg rooted circuits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1175
Signatures have three components:
Many interesting replacements in a graph changes the latter, but
SiblingSubgraph::create_simple_replacementrequired the signatures to match exactly.