feat: Add ConstExternalSymbol to prelude
#1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #233.
doug-q
changed the title
ConstExternalSymbolConstExternalSymbol to prelude
aborgna-q
approved these changes
May 30, 2024
| /// A structure for holding references to external symbols. | ||
| pub struct ConstExternalSymbol { | ||
| /// The symbol name that this value refers to. Must be nonempty. | ||
| pub symbol: String, |
There was a problem hiding this comment.
Should we add a type alias for this, akin to ValueName / ValueNameRef ?
There was a problem hiding this comment.
I don't think so. This is intended to be the literal linker symbol name that a LoadConstant of this const will lower to reading.
This was referenced May 31, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
## 🤖 New release * `hugr`: 0.5.0 -> 0.5.1 * `hugr-core`: 0.1.0 -> 0.2.0 * `hugr-passes`: 0.1.0 -> 0.2.0 * `hugr-cli`: 0.1.0 -> 0.1.1 <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## 0.5.1 (2024-06-07) ### Refactor - Move binary to hugr-cli ([#1134](#1134)) </blockquote> ## `hugr-core` <blockquote> ## 0.2.0 (2024-06-07) ### Bug Fixes - [**breaking**] Validate that control-flow outputs have exactly one successor ([#1144](#1144)) - Do not require matching extension_reqs when creating a replacement ([#1177](#1177)) ### Features - Add `ConstExternalSymbol` to prelude ([#1123](#1123)) - `HugrView::extract_hugr` to extract regions into owned hugrs. ([#1173](#1173)) ### Testing - Serialisation round trip testing for `OpDef` ([#999](#999)) </blockquote> ## `hugr-passes` <blockquote> ## 0.2.0 (2024-06-07) ### Features - Add `ValidationLevel` tooling and apply to `constant_fold_pass` ([#1035](#1035)) </blockquote> ## `hugr-cli` <blockquote> ## 0.1.1 (2024-06-07) ### Features - Reexport `clap::Parser` and `clap_verbosity_flag::Level` from hugr_cli ([#1146](#1146)) ### Refactor - Move binary to hugr-cli ([#1134](#1134)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #233.