Refactor: move non_df_count out from OpValidityFlags
#521
Assignees
Comments
ss2165
added a commit
that referenced
this issue
Nov 11, 2023
ss2165
added a commit
that referenced
this issue
Nov 13, 2023
ss2165
added a commit
that referenced
this issue
Nov 13, 2023
ss2165
added a commit
that referenced
this issue
Nov 13, 2023
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 15, 2023
- [x] Closes #495 - [x] Closes #521 - [x] Closes #655 - [x] Closes #499 - [x] Closes #506 - [x] Closes #653 - [x] `OpType::signature` returns option (non-dataflow ops don't return signature) - [x] Implement `try_into` from OpType references in to inner references. Doesn't necessarily do exactly as those issues specify - instead considers them holistically for a more unified interface. Easiest to review commit by commit. Uses rust_version crate to use return position impl for the new `HugrView` methods that return iterators. This will be stable with 1.75 (which enters beta in a few days). BREAKING_CHANGES: `OpType` and `FunctionType` methods renamed for clarity; `OpType::signature` returns `Option<FuncType>`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
....as it's not used in validation, and is used in public methods of OpType:
non_df_countandget_port_indexCould then follow up by renaming
OpValidityFlagsto something likeOpChildFlagsas all remaining flags would relate to children.The text was updated successfully, but these errors were encountered: